Skip to content

🌱 BundleDeployment Cleanup - #1061

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
dtfranz:rm-bd
Jul 18, 2024
Merged

🌱 BundleDeployment Cleanup#1061
tmshort merged 1 commit into
operator-framework:mainfrom
dtfranz:rm-bd

Conversation

@dtfranz

@dtfranzdtfranz commented Jul 17, 2024•
edited by tmshort
Loading

Copy link
Copy Markdown
Contributor

Fixes: #998
Cleans up some of the baggage that came with the BundleDeployment API from rukpak.

Changes:

  • Rename BundleDeployment -> BundleSource
  • Remove unneeded DeepCopy generated funcs
  • Remove more unused fields and consts
  • Move BundleSource type into Unpacker pkg

@dtfranz
dtfranz requested a review from a team as a code ownerJuly 17, 2024 21:13
@netlify

netlifyBot commented Jul 17, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit0a8cf9e
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66984bf2f1487100088aab4e
😎 Deploy Previewhttps://deploy-preview-1061--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jul 17, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (6cd022e) to head (0a8cf9e).
Report is 6 commits behind head on main.

FilesPatch %Lines
internal/rukpak/source/unpacker.go0.00%9 Missing ⚠️
internal/rukpak/source/image_registry.go60.00%2 Missing and 4 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1061 +/- ##
==========================================
+ Coverage 72.50% 72.85% +0.34% 
==========================================
Files 32 31 -1 Lines 1884 1864 -20 ==========================================
- Hits 1366 1358 -8 + Misses 383 371 -12 
Partials 135 135
FlagCoverage Δ
e2e55.51% <50.00%> (+0.17%)⬆️
unit45.01% <20.00%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfranz
BundleSource cleanup
0a8cf9e
Signed-off-by: dtfranz <dfranz@redhat.com>
tmshort
tmshort approved these changes Jul 18, 2024
View reviewed changes

@tmshorttmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@tmshort
tmshort added this pull request to the merge queue Jul 18, 2024
Merged via the queue into operator-framework:main with commit cae1cf1Jul 18, 2024
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
@dtfranzPer Goncalves da Silva
BundleSource cleanup (operator-framework#1061)
9006157
Signed-off-by: dtfranz <dfranz@redhat.com>
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
@dtfranzPer Goncalves da Silva
BundleSource cleanup (operator-framework#1061)
6226956
Signed-off-by: dtfranz <dfranz@redhat.com>
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmshorttmshorttmshort approved these changes

Assignees

@tmshorttmshort

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove use of BundleDeployment API

2 participants

@dtfranz@tmshort