Uh oh!
There was an error while loading. Please reload this page.
✨ wire up ServiceAccount based caching layer - #1074
Merged
tmshort merged 2 commits intoJul 22, 2024
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1074 +/- ##
==========================================
- Coverage 72.93% 72.82% -0.11%
==========================================
Files 31 32 +1 Lines 1862 1866 +4 ==========================================
+ Hits 1358 1359 +1 - Misses 366 368 +2 - Partials 138 139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading. Please reload this page.
everettravenforce-pushed
the
feature/wire-sa-cache
branch
from
July 22, 2024 14:20
941737c to
274df7eCompareeverettravenforce-pushed
the
feature/wire-sa-cache
branch
from
July 22, 2024 14:23
274df7e to
b2dc337CompareSigned-off-by: everettraven <everettraven@gmail.com>
everettravenforce-pushed
the
feature/wire-sa-cache
branch
from
July 22, 2024 14:30
b2dc337 to
5e51907CompareSigned-off-by: everettraven <everettraven@gmail.com>
@skattoju: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tmshort
reviewed
Jul 22, 2024
| acg, err := action.NewWrappedActionClientGetter(cfgGetter, | ||
| helmclient.WithFailureRollbacks(false), | ||
| ) | ||
tmshort
reviewed
Jul 22, 2024
| }, | ||
| })). | ||
| Build(r) | ||
tmshort
approved these changes
Jul 22, 2024
tmshort
left a comment
Contributor
There was a problem hiding this comment.
/lgtm
Just small wicked minor nits.
tmshort
added this pull request to the merge queue
Jul 22, 2024
perdasilva pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
* wire up serviceaccount based caching layer Signed-off-by: everettraven <everettraven@gmail.com> * remove body close Signed-off-by: everettraven <everettraven@gmail.com> --------- Signed-off-by: everettraven <everettraven@gmail.com>
perdasilva pushed a commit
to kevinrizza/operator-controller
that referenced
this pull request
Aug 13, 2024
* wire up serviceaccount based caching layer Signed-off-by: everettraven <everettraven@gmail.com> * remove body close Signed-off-by: everettraven <everettraven@gmail.com> --------- Signed-off-by: everettraven <everettraven@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TokenTripperthat wraps ahttp.RoundTripperto always set the Authorization header to the referenced ServiceAccountbind+escalatefor RBAC to keep the SA permissions as succinct as possible. Open to changing this if desired)ClusterExtensionReconcilerto have an exported field that can be used to configure thecontentmanager.Watcherthat should be used to establish watches on the ClusterExtension managed objectscontentmanager.Instance.Watch()method to create watches with the same configurations as existed in theClusterExtensionReconciler.reconcile()method previouslyresolves#975
resolves#983
Reviewer Checklist