🌱 Internal Rukpak Package Tests

[dtfranz]

Adds more tests to the packages migrated from rukpak.

Closes#1037

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	916f9e4
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/66c36ba86567ba000839a751
😎 Deploy Preview	https://deploy-preview-1100--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (74959d0) to head (916f9e4).
Report is 12 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1100 +/- ##
==========================================
+ Coverage 75.44% 76.85% +1.40% 
==========================================
Files 35 35 Lines 1918 1918 ==========================================
+ Hits 1447 1474 +27 + Misses 329 310 -19 + Partials 142 134 -8 

Flag	Coverage Δ
e2e	58.08% <ø> (-0.11%)	⬇️
unit	54.58% <ø> (+3.70%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[everettraven]

Tests look fine to me in this file.

I think it might be worth comparing what they look like in catalogd: https://github.com/operator-framework/catalogd/blob/main/internal/source/image_registry_client_test.go

It looks like there may be some more complexity in this set of tests for serving the manifests. Maybe we could simplify it by using the same method of standing up and populating an image registry for testing that catalogd does?

[everettraven]

Just to clarify, this is not something that I think should block this PR from going in. Just something that stood out to me during review and having the contextual knowledge that we implemented unit tests for similar functionality in catalogd a while back

[dtfranz]

Thanks for showing me that! I missed that in there; I'll follow that example and see how much simplification can be done in here.

[everettraven]

Overall looks good to me. Left a general comment for comparison of the image registry tests implemented here and in catalogd, but it doesn't need to be addressed for this PR to merge IMO.

[dtfranz]

Overall looks good to me. Left a general comment for comparison of the image registry tests implemented here and in catalogd, but it doesn't need to be addressed for this PR to merge IMO.

It currently looks to me like I'll need to keep the low-level http response stuff in there for some of the error returns; I'll revisit this at another time and merge for now. Thank you!