Skip to content

✨ update ClusterExtension.Spec.PakageName to be immutable - #1157

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
yashoza19:issue1152
Aug 21, 2024
Merged

✨ update ClusterExtension.Spec.PakageName to be immutable#1157
everettraven merged 1 commit into
operator-framework:mainfrom
yashoza19:issue1152

Conversation

@yashoza19

@yashoza19yashoza19 commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes#1152

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@yashoza19
yashoza19 requested a review from a team as a code ownerAugust 20, 2024 18:30
@netlify

netlifyBot commented Aug 20, 2024•
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for olmv1 failed.

NameLink
🔨 Latest commit2100bd1
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66c5ef766abdfb000864433e

@codecov

codecovBot commented Aug 20, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (1fb6bd2) to head (2100bd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1157 +/- ##
=======================================
Coverage 75.45% 75.45% =======================================
Files 35 35 Lines 1919 1919 =======================================
Hits 1448 1448 Misses 329 329 Partials 142 142
FlagCoverage Δ
e2e58.10% <ø> (-0.11%)⬇️
unit50.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven reviewed Aug 20, 2024
View reviewed changes
Comment threadconfig/base/crd/bases/olm.operatorframework.io_clusterextensions.yaml Outdated
Comment on lines +108 to +110
x-kubernetes-validations:
- message: packageName is immutable
rule: self == oldSelf

@everettraveneverettravenAug 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might be some formatting issues here causing the sanity/verify check to fail.

@yashoza19yashoza19Aug 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to have passed the sanity check, but still fails on tilt.

@everettraveneverettravenAug 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tilt check is currently expected to fail based on some recent changes that were made in catalogd. I don't think it is a required check.

@yashoza19
update ClusterExtension.Spec.PakageName to be immutable
2100bd1
Signed-off-by: yashoza19 <yoza@redhat.com>
@everettraven
everettraven added this pull request to the merge queue Aug 21, 2024
@everettraven
everettraven removed this pull request from the merge queue due to a manual request Aug 21, 2024
@everettraven
everettraven added this pull request to the merge queue Aug 21, 2024
Merged via the queue into operator-framework:main with commit 37c64bdAug 21, 2024
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the ClusterExtension.Spec.PackageName field to be immutable

2 participants

@yashoza19@everettraven