Uh oh!
There was an error while loading. Please reload this page.
📖 Update GoDoc comments for the ClusterExtension API - #1158
Merged
everettraven merged 5 commits intoAug 22, 2024
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1158 +/- ##
=======================================
Coverage 75.45% 75.45% =======================================
Files 35 35 Lines 1919 1919 =======================================
Hits 1448 1448 Misses 329 329 Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
everettraven
commented
Aug 21, 2024
ContributorAuthor
There are a couple PRs that are in the merge queue that will require a rebase for these changes. Adding a hold for now /hold |
Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
everettravenforce-pushed
the
v1-api-comments
branch
from
August 21, 2024 20:12
4c3fb5e to
3814fa0CompareSigned-off-by: everettraven <everettraven@gmail.com>
everettraven
commented
Aug 21, 2024
ContributorAuthor
Rebased on latest merged API changes. unholding /hold cancel |
everettraven
enabled auto-merge
August 21, 2024 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the GoDoc comments in the
ClusterExtensionAPI to be more user readable, user the JSON field name in references, and ensures all optional fields are marked with the//+optionalcomment tag// +optionaltag #1147Reviewer Checklist