Uh oh!
There was an error while loading. Please reload this page.
⚠ Implement API changes according to RFC spec - #1166
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
everettraven
left a comment
There was a problem hiding this comment.
Thanks for this PR @jsm84 !
Requesting changes on my current comments. I'll be out tomorrow, so I'll circle around for further review on Monday.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1166 +/- ##
==========================================
- Coverage 77.55% 77.18% -0.38%
==========================================
Files 35 35 Lines 1916 1937 +21 ==========================================
+ Hits 1486 1495 +9 - Misses 296 308 +12
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading. Please reload this page.
everettraven
commented
Aug 26, 2024
Just finished combing through the rest of the PR and I don't have any additional comments |
a991906 to
00528fcCompare
everettraven
left a comment
There was a problem hiding this comment.
Some more comments on the comments. Overall I think they are good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f188dd1 to
fe81727Compare
everettraven
left a comment
There was a problem hiding this comment.
Changes looks good to me, thanks for the contribution @jsm84 !
I finished my review on mobile and it doesn't look like I can kick CI via the GH mobile app. I'll kick it first thing tomorrow morning and try to get this merged.
Uh oh!
There was an error while loading. Please reload this page.
everettraven
commented
Aug 29, 2024
Closing and re-opening to try and reset the netlify checks that seem to be stuck |
resolvesoperator-framework#1088 Summary: * v1 API now uses a `SourceConfig` discriminated union which will allow modularity for future install sources (bundles, charts, etc). * `SourceConfig` uses CEL validation to ensure only valid field names & values are utilized (`sourceType: Catalog` ensures that the `catalog` field is also set in `SourceConfig`). * Added new `clusterextension_admission` unit test for `SourceConfig` objects. The test covers both valid and invalid cases. * Fixed `clusterextension_controller` test where an unset `ClusterExtension` spec caused a null pointer deref. * Moved `ClusterSelector` from `ClusterExtension.Spec` to `ClusterExtension.Source.Catalog` and renamed to `Selector`. * Updated GoDocs to reflect the new API spec and included post-review changes * Fixed all definitions of `kind: ClusterExtension` in docs and scripts to reflect the API changes. Signed-off-by: Josh Manning <19478595+jsm84@users.noreply.github.com>
resolves#1088
Summary:
SourceConfigdiscriminated union which will allow modularity for future install sources (bundles, charts, etc).SourceConfiguses CEL validation to ensure only valid field names & values are utilized (sourceType: Catalogensures that thecatalogfield is also set inSourceConfig).clusterextension_admissionunit test forSourceConfigobjects. The test covers both valid and invalid cases.clusterextension_controllertest where an unsetClusterExtensionspec caused a null pointer deref.ClusterSelectorfromClusterExtension.SpectoClusterExtension.Source.Catalogand renamed to
Selector.kind: ClusterExtensionin docs and scriptsto reflect the API changes.