Skip to content

✨ Add ServedVersionValidator preflight check - #1191

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
trgeiger:crd-upgrade
Aug 30, 2024
Merged

✨ Add ServedVersionValidator preflight check#1191
everettraven merged 1 commit into
operator-framework:mainfrom
trgeiger:crd-upgrade

Conversation

@trgeiger

@trgeigertrgeiger commented Aug 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

New preflight check that checks for either the presence of the "Webhook" conversion strategy to pass, or checks for any incompatible changes between served versions in the new CRD which, if found, causes failure..

Closes#1091

Description

Adds a new preflight check, ServedVersionValidator, which checks for breaking changes between served versions in the new CRD when upgrading.

Happy to change up any naming or error messages.

Existing test data had to be edited so it wouldn't trigger the new check--the empty v1 in all the test data has just been filled in to match the test data v2.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@trgeiger
trgeiger requested a review from a team as a code ownerAugust 29, 2024 15:59
@netlify

netlifyBot commented Aug 29, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2716b3b
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66d1da88fc37470008d537f3
😎 Deploy Previewhttps://deploy-preview-1191--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Aug 29, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (37c64bd) to head (2716b3b).
Report is 25 commits behind head on main.

Files with missing linesPatch %Lines
...ernal/rukpak/preflights/crdupgradesafety/checks.go94.28%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1191 +/- ##
==========================================
+ Coverage 75.45% 77.56% +2.10% 
==========================================
Files 35 36 +1 Lines 1919 1979 +60 ==========================================
+ Hits 1448 1535 +87 + Misses 329 309 -20 + Partials 142 135 -7
FlagCoverage Δ
e2e57.65% <28.57%> (-0.56%)⬇️
unit55.53% <95.91%> (+4.67%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven suggested changes Aug 29, 2024
View reviewed changes

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look really good! Great work @trgeiger !

I have a couple minor comments, but ones I think are worth addressing

Comment threadinternal/rukpak/preflights/crdupgradesafety/checks.go Outdated
Comment threadinternal/rukpak/preflights/crdupgradesafety/checks.go
@trgeiger
Add ServedVersionValidator preflight check
2716b3b
New preflight check that checks for either the presence of the "Webhook"
conversion strategy to pass, or checks for any incompatible changes
between served versions in the new CRD which, if found, causes failure..
Closesoperator-framework#1091
Signed-off-by: Tayler Geiger <tayler@redhat.com>
@trgeiger

trgeiger commented Aug 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review and suggestions. All ready to go again.

everettraven
everettraven approved these changes Aug 30, 2024
View reviewed changes

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@everettraven
everettraven added this pull request to the merge queue Aug 30, 2024
Merged via the queue into operator-framework:main with commit 0e728b3Aug 30, 2024
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CRD Upgrade Safety preflight checks should check for incompatibility between served versions

2 participants

@trgeiger@everettraven