Skip to content

🌱 Define a constant for the finaliser key - #1209

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
m1kola:finaliser_key_constant
Sep 3, 2024
Merged

🌱 Define a constant for the finaliser key#1209
tmshort merged 1 commit into
operator-framework:mainfrom
m1kola:finaliser_key_constant

Conversation

@m1kola

Copy link
Copy Markdown
Member

Description

Moving finaliser key to a constant instead of dynamically generating it. We do it the same way in catalod. Another finalisers will be added in #1207 in a similar way.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kola requested a review from a team as a code ownerSeptember 3, 2024 14:32
@netlify

netlifyBot commented Sep 3, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commite0f0ccf
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66d71dfa63f74b0008124d63
😎 Deploy Previewhttps://deploy-preview-1209--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Sep 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.53%. Comparing base (39c893c) to head (e0f0ccf).
Report is 5 commits behind head on main.

Files with missing linesPatch %Lines
cmd/manager/main.go50.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1209 +/- ##
==========================================
- Coverage 77.55% 77.53% -0.03% 
==========================================
Files 36 36 Lines 1978 1976 -2 ==========================================
- Hits 1534 1532 -2 
Misses 309 309 Partials 135 135 
FlagCoverage Δ
e2e57.59% <50.00%> (-0.05%)⬇️
unit55.61% <0.00%> (+0.05%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshorttmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@tmshort
tmshort added this pull request to the merge queue Sep 3, 2024
Merged via the queue into operator-framework:main with commit 5800c7fSep 3, 2024
@m1kola
m1kola deleted the finaliser_key_constant branch September 4, 2024 07:02
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola@tmshort