Skip to content

📖[Docs] How-to: Channel-Based Automatic Updates - #1220

Merged
joelanford merged 1 commit into
operator-framework:mainfrom
perdasilva:perdasilva/docs/howto-channel-based-upgd
Sep 7, 2024
Merged

📖[Docs] How-to: Channel-Based Automatic Updates#1220
joelanford merged 1 commit into
operator-framework:mainfrom
perdasilva:perdasilva/docs/howto-channel-based-upgd

Conversation

@perdasilva

@perdasilvaperdasilva commented Sep 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes#1129

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva
perdasilva requested a review from a team as a code ownerSeptember 5, 2024 15:33
@netlify

netlifyBot commented Sep 5, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2efe604
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66db1286446bda0008263a32
😎 Deploy Previewhttps://deploy-preview-1220--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Sep 5, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (3a9868e) to head (2efe604).
Report is 38 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1220 +/- ##
==========================================
- Coverage 77.55% 76.49% -1.07% 
==========================================
Files 35 40 +5 Lines 1916 2340 +424 ==========================================
+ Hits 1486 1790 +304 - Misses 296 393 +97 - Partials 134 157 +23
FlagCoverage Δ
e2e57.64% <ø> (-1.12%)⬇️
unit52.43% <ø> (-2.84%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven reviewed Sep 5, 2024
View reviewed changes
Comment threaddocs/drafts/how-to-channel-based-upgrades.md Outdated
OchiengEd
OchiengEd suggested changes Sep 5, 2024
View reviewed changes

@OchiengEdOchiengEd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I recommend slight rewording

Comment threaddocs/drafts/how-to-channel-based-upgrades.md Outdated
name: argocd-installer
```

Note that the `version` version range can also be set to further restrict the set of possible versions to upgrade to.

@OchiengEdOchiengEdSep 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be made clearer. Perhaps something like,

Note that the `version` field also accepts a version range to further restrict the set of possible operator versions to upgrade to.

@perdasilvaperdasilvaSep 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!!

I've updated it and tried to remove the preposition at the end? wdyt?

@perdasilva
perdasilvaforce-pushed the perdasilva/docs/howto-channel-based-upgd branch 2 times, most recently from 17e52f2 to e928d0aCompareSeptember 6, 2024 08:01
everettraven
everettraven reviewed Sep 6, 2024
View reviewed changes
Comment threaddocs/drafts/how-to-channel-based-upgrades.md Outdated
everettraven
everettraven reviewed Sep 6, 2024
View reviewed changes
Comment threaddocs/drafts/how-to-channel-based-upgrades.md Outdated
Per Goncalves da Silva
📖[Docs] How-to: Channel-Based Automatic Updates
2efe604
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
perdasilvaforce-pushed the perdasilva/docs/howto-channel-based-upgd branch from e928d0a to 2efe604CompareSeptember 6, 2024 14:32
@everettraven
everettraven added this pull request to the merge queue Sep 6, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@joelanford
joelanford added this pull request to the merge queue Sep 7, 2024
Merged via the queue into operator-framework:main with commit ac5c28bSep 7, 2024
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordjoelanford approved these changes
+2 more reviewers
@OchiengEdOchiengEdOchiengEd requested changes
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Accept automatic upgrades within a specific channel

4 participants

@perdasilva@OchiengEd@joelanford@everettraven