Uh oh!
There was an error while loading. Please reload this page.
🌱 Update to catalogd v0.26.0 and update e2e tests - #1237
Conversation
* Use proper labels from catalogd * Add better deployment checking * Fix broken test This test seems broken, it's supposed to resolve again after updating to V2. The test implies that this should be the 2.0.0 version, but it's checking against 1.2.0 (which was the original version installed). Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| Name: "prometheus-operator.2.0.0", | ||
| Version: "2.0.0", |
There was a problem hiding this comment.
The original test seemed wrong. The catalog is updated to v2.0, but it remains as 1.2.0? That doesn't seem right. With the latest changes this now seems to be behaving as expected.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1237 +/- ##
=======================================
Coverage 76.53% 76.53% =======================================
Files 40 40 Lines 2340 2340 =======================================
Hits 1791 1791 Misses 392 392 Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Todd Short <tshort@redhat.com>
| # Wait for the rollout, and then wait for the deployment to be Available | ||
| kubectl_wait_rollout "olmv1-system" "deployment/catalogd-controller-manager" "60s" |
There was a problem hiding this comment.
The deployment is updated with the latest cert secret, so this will wait for the rollout to complete, and the next step will ensure that it's ready.
| Name: name, | ||
| Labels: map[string]string{"olm.operatorframework.io/name": name}, |
There was a problem hiding this comment.
This label is now added automatically by v0.26.0 of catalogd
Fix#1115
This test seems broken, it's supposed to resolve again after updating to V2. The test implies that this should be the 2.0.0 version, but it's checking against 1.2.0 (which was the original version installed).
Description
Reviewer Checklist