Skip to content

✨ Simplify status condition reasons - #1241

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
oceanc80:simplify-status-conditions
Sep 10, 2024
Merged

✨ Simplify status condition reasons#1241
tmshort merged 1 commit into
operator-framework:mainfrom
oceanc80:simplify-status-conditions

Conversation

@oceanc80

Copy link
Copy Markdown
Contributor

Description

Simplifies status condition types per the v1 API Review RFC. Succeeded and Failed are used for all the status condition types (Unpacked, Installed, Resolved) to ensure consistency.

Fixes#1153

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@oceanc80
oceanc80 requested a review from a team as a code ownerSeptember 9, 2024 23:15
@netlify

netlifyBot commented Sep 9, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit054e6b4
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66e04920cd2bf4000768c7e8
😎 Deploy Previewhttps://deploy-preview-1241--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Sep 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (0741d36) to head (054e6b4).
Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
...nternal/controllers/clusterextension_controller.go66.66%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1241 +/- ##
==========================================
- Coverage 76.53% 76.45% -0.09% 
==========================================
Files 40 40 Lines 2340 2336 -4 ==========================================
- Hits 1791 1786 -5 - Misses 392 393 +1 
Partials 157 157 
FlagCoverage Δ
e2e57.57% <62.50%> (-0.08%)⬇️
unit52.35% <87.50%> (-0.13%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oceanc80
oceanc80force-pushed the simplify-status-conditions branch 2 times, most recently from 5f9ecb8 to 6d3af51CompareSeptember 10, 2024 12:54
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
@oceanc80
oceanc80force-pushed the simplify-status-conditions branch from 6d3af51 to 054e6b4CompareSeptember 10, 2024 13:26

@tmshorttmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@tmshort

Copy link
Copy Markdown
Contributor

API diff is acceptable.

@tmshort
tmshort added this pull request to the merge queue Sep 10, 2024
Merged via the queue into operator-framework:main with commit 871c883Sep 10, 2024
@oceanc80
oceanc80 deleted the simplify-status-conditions branch September 10, 2024 14:42
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify the reasons used in status conditions to only Succeeded and Failed

2 participants

@oceanc80@tmshort