Uh oh!
There was an error while loading. Please reload this page.
🐛 Fix follow-up for bumping catalogd to v0.36.0: Replace pollInterval for pollIntervalMinutes - #1442
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d30bc8b to
69c5a0fCompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1442 +/- ##
==========================================
+ Coverage 74.88% 74.91% +0.03%
==========================================
Files 42 42 Lines 3241 3241 ==========================================
+ Hits 2427 2428 +1 + Misses 643 642 -1
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
commented
Nov 11, 2024
We need to fix a lot more issues in our examples and docs. I'm working on it here: #1443 |
m1kola
left a comment
There was a problem hiding this comment.
@camilamacedo86 could you please do the following?
- Update
hack/test/pre-upgrade-setup.shto havepollIntervalMinutes: 1440. - Revert changes from
doc. We will address this stuff in #1443.
After that - we can merge your PR and cut a new release. This should fix upgrade-e2e
Uh oh!
There was an error while loading. Please reload this page.
69c5a0f to
d2acae2Compared2acae2 to
ff65eb8CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ff65eb8 to
9fc3f7bCompareUh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
9fc3f7b to
6771675Compare6771675 to
1ce3876Compare…ith pollIntervalMinutes in ClusterCatalog spec and update documentation references In operator-framework#1434, the API was updated to use pollIntervalMinutes instead of pollInterval. This commit ensures that all references to pollInterval are correctly replaced with pollIntervalMinutes across the ClusterCatalog spec and relevant documentation. See: https://github.com/operator-framework/operator-controller/pull/1434/files#diff-93b46b0715181c9cf397eed60862261b7839ff721599fcc393a393b9edea610bR57
1ce3876 to
01c0f0bComparecamilamacedo86
commented
Nov 11, 2024
Hi @m1kola I will leave this one open c/c @tylerslaton ^ |
In #1434, the API was updated to use
pollIntervalMinutesinstead ofpollInterval. This commit ensures all references are properly updated.See: https://github.com/operator-framework/operator-controller/pull/1434/files#diff-93b46b0715181c9cf397eed60862261b7839ff721599fcc393a393b9edea610bR57
Example of issue:
If we follow up the docs before this change: