Uh oh!
There was an error while loading. Please reload this page.
🌱 Fix upgrade-e2e CI job - #1445
Merged
Merged
Conversation
There were several intentional breaking changes in the API which are now included in v0.18.0 release. Our upgrade-e2e job need to be updated to make take the changes into account. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1445 +/- ##
==========================================
+ Coverage 74.88% 74.91% +0.03%
==========================================
Files 42 42 Lines 3241 3241 ==========================================
+ Hits 2427 2428 +1 + Misses 643 642 -1
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
marked this pull request as ready for review
November 12, 2024 13:12
m1kola
commented
Nov 12, 2024
MemberAuthor
There are more changes to address related to the API changes (in documentation in particular), but this is going to be a separate effort. This PR is up to make sure that our PRs do not fail upgrade-e2e job. |
joelanford
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were several intentional breaking changes in the API which are now included in v0.18.0 release.
Our upgrade-e2e job need to be updated to make take the changes into account.
Relevant PRs:
.spec.install.namespaceand.spec.install.serviceAccountto.spec.namespaceand.spec.serviceAccount#1439Reviewer Checklist