Skip to content

Refactoring kustomize to simplify e2e of feature gates - #1949

Closed
joelanford wants to merge 5 commits into
operator-framework:mainfrom
joelanford:refactoring-kustomize
Closed

Refactoring kustomize to simplify e2e of feature gates#1949
joelanford wants to merge 5 commits into
operator-framework:mainfrom
joelanford:refactoring-kustomize

Conversation

@joelanford

@joelanfordjoelanford commented May 5, 2025•
edited by camilamacedo86
Loading

Copy link
Copy Markdown
Member

Description

Extremely rough draft PR to refactor kustomize and make it easier to compose overlays for the purpose of building "community-ga" vs "community-ga-e2e" vs "community-beta" vs "community-beta-e2e"

Closes: #1991

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2025
@netlify

netlifyBot commented May 5, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit8f552ed
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68287175798d380008e9f4cf
😎 Deploy Previewhttps://deploy-preview-1949--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joelanfordjoelanford changed the title Refactoring kustomizeRefactoring kustomize to simplify e2e of feature gatesMay 5, 2025
@joelanford
initial refactoring
c728cf6
@joelanford
update 'make manifests'
7bf9b64
@joelanford
fixed e2e tests (via refactoring of image registry setup)
141e97e
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
replace old config, simply testdata image build, add tilt component
da98fd3
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
fix Tiltfile manifest
8f552ed
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford
joelanfordforce-pushed the refactoring-kustomize branch from 1b98699 to 8f552edCompareMay 17, 2025 11:22
@openshift-ci

openshift-ciBot commented May 17, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
@tmshorttmshort mentioned this pull request May 19, 2025
Merged
4 tasks
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2025
@openshift-merge-robot

openshift-merge-robot commented May 24, 2025

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 27, 2025
Closed
Merged
@tmshort

tmshort commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

time to close this?

@camilamacedo86

camilamacedo86 commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

@joelanford
I am closing this one since it seems achived
But if you see fit, please feel free to re-open.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update kustomize files Make it easy to toggle feature flags on and off during end-to-end (E2E) tests.

4 participants

@joelanford@openshift-merge-robot@tmshort@camilamacedo86