Skip to content

✨ Update releaser to use env variables - #1974

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:update-goreleaser
May 22, 2025
Merged

✨ Update releaser to use env variables#1974
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:update-goreleaser

Conversation

@tmshort

@tmshorttmshort commented May 19, 2025

Copy link
Copy Markdown
Contributor

In anticipation of config changes.
Use environment variables for the release values.
Update the Makefile to use the same variables.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerMay 19, 2025 17:12
@netlify

netlifyBot commented May 19, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commita5ec854
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/682e20424996ac0008e967b5
😎 Deploy Previewhttps://deploy-preview-1974--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented May 19, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (cecd003) to head (a5ec854).
Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1974 +/- ##
=======================================
Coverage 69.11% 69.11% =======================================
Files 79 79 Lines 7023 7023 =======================================
Hits 4854 4854 Misses 1887 1887 Partials 282 282
FlagCoverage Δ
e2e43.11% <ø> (ø)
unit59.97% <ø> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
tmshortforce-pushed the update-goreleaser branch from 2c1a935 to ea0d61eCompareMay 19, 2025 17:38
@tmshort

tmshort commented May 19, 2025

Copy link
Copy Markdown
ContributorAuthor

This is the goreleaser parts from #1949

camilamacedo86
camilamacedo86 approved these changes May 19, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine for me 👍

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@openshift-ci

openshift-ciBot commented May 19, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
joelanford
joelanford reviewed May 19, 2025
View reviewed changes
Comment threadMakefile Outdated
@tmshort
tmshortforce-pushed the update-goreleaser branch from ea0d61e to 2daed93CompareMay 20, 2025 17:45
@openshift-ciopenshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@tmshort
tmshortforce-pushed the update-goreleaser branch from 2daed93 to b4a3fb1CompareMay 21, 2025 13:18
joelanford
joelanford reviewed May 21, 2025
View reviewed changes
Comment threadMakefile Outdated
@tmshort
Update releaser to use env variables
a5ec854
In anticipation of config changes.
Use environment variables for the release values.
Update the Makefile to use the same variables.
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshortforce-pushed the update-goreleaser branch from b4a3fb1 to a5ec854CompareMay 21, 2025 18:49
@camilamacedo86

camilamacedo86 commented May 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @tmshort

Let's do the 1.3.0 release, then we merge this one, and we can do an RC just to ensure that all is still working well as expected. Can we hold up there?

I am adding

/hold

But feel free to unhold if/when you need.

@perdasilva

perdasilva commented May 22, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

/hold (for @camilamacedo86 as hers didn't seem to take effect...?)

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
@tmshort

tmshort commented May 22, 2025

Copy link
Copy Markdown
ContributorAuthor

It's not going anywhere without an LGTM
Please unhold once you've released.

@camilamacedo86

camilamacedo86 commented May 22, 2025

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
camilamacedo86
camilamacedo86 reviewed May 22, 2025
View reviewed changes

@camilamacedo86camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 71108b2 into operator-framework:mainMay 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordjoelanford left review comments
@camilamacedo86camilamacedo86camilamacedo86 approved these changes
@gavinmbellgavinmbellAwaiting requested review from gavinmbell

Assignees

@camilamacedo86camilamacedo86

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort@camilamacedo86@perdasilva@joelanford