Uh oh!
There was an error while loading. Please reload this page.
🐛 (e2e) fix namespaces network-policy test searches in - #2034
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 23, 2025
Conversation
The test was previously listing networkpolicies to validate only in the namespace operator-controller is deployed in. Upstream, that is valid since the namespace that operator-controller is deployed in, is the namespace that all other components are deployed in (and therefore all the network polices we expect to find). A different distribution of olmv1 (downstream) could decide to deploy the policies in different namespaces, in which case the test will not look into all the namespaces it should look into. This PR fixes the issue by searching in the namespaces both operator-controller and catalogd is deployed in.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #2034 +/- ##
=======================================
Coverage 73.83% 73.83% =======================================
Files 80 80 Lines 7154 7154 =======================================
Hits 5282 5282 Misses 1549 1549 Partials 323 323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anik120 added a commit
to anik120/operator-controller
that referenced
this pull request
Jun 23, 2025
Follow up to (2034)[operator-framework#2034] When there is a dual namespace deployment, the default-deny-all policy is duplicated in both namespaces. This PR updates the list of `allowedPolicies` to include both policies if a dual namespace deployment is detected.
4 tasks
openshift-merge-botBot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Follow up to (2034)[#2034] When there is a dual namespace deployment, the default-deny-all policy is duplicated in both namespaces. This PR updates the list of `allowedPolicies` to include both policies if a dual namespace deployment is detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was previously listing networkpolicies to validate only in the namespace operator-controller is deployed in.
Upstream, that is valid since the namespace that operator-controller is deployed in, is the namespace that all other components are deployed in (and therefore all the network polices we expect to find).
A different distribution of olmv1 (downstream) could decide to deploy the policies in different namespaces, in which case the test will not look into all the namespaces it should look into.
This PR fixes the issue by searching in the namespaces both operator-controller and catalogd is deployed in.
Description
Reviewer Checklist