Skip to content

🐛 (e2e) fix default-deny-all in list of allowed policies for test - #2039

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
anik120:np-test-fix-2
Jun 23, 2025
Merged

🐛 (e2e) fix default-deny-all in list of allowed policies for test#2039
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
anik120:np-test-fix-2

Conversation

@anik120

@anik120anik120 commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Follow up to 2034

When there is a dual namespace deployment, the default-deny-all policy is duplicated in both namespaces.

This PR updates the list of allowedPolicies to include both policies if a dual namespace deployment is detected.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120
(e2e) fix default-deny-all in list of allowed policies for test
1f51575
Follow up to (2034)[operator-framework#2034]
When there is a dual namespace deployment, the default-deny-all policy
is duplicated in both namespaces.
This PR updates the list of `allowedPolicies` to include both policies
if a dual namespace deployment is detected.
@anik120
anik120 requested a review from a team as a code ownerJune 23, 2025 18:10
@netlify

netlifyBot commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit1f51575
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/6859988d6a04280008ef03c8
😎 Deploy Previewhttps://deploy-preview-2039--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecovBot commented Jun 23, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (dffa0f6) to head (1f51575).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2039 +/- ##
=======================================
Coverage 73.81% 73.81% =======================================
Files 80 80 Lines 7154 7154 =======================================
Hits 5281 5281 Misses 1550 1550 Partials 323 323
FlagCoverage Δ
e2e44.10% <ø> (ø)
unit60.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@openshift-ci

openshift-ciBot commented Jun 23, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit d844c45 into operator-framework:mainJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86camilamacedo86Awaiting requested review from camilamacedo86
@thetechnickthetechnickAwaiting requested review from thetechnick

Assignees

@tmshorttmshort

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anik120@tmshort