Uh oh!
There was an error while loading. Please reload this page.
🐛 dynamically create containerd registry config file for e2e - #2203
🐛 dynamically create containerd registry config file for e2e#2203anik120 wants to merge 1 commit into
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #2203 +/- ##
==========================================
- Coverage 72.05% 72.03% -0.03%
==========================================
Files 85 85 Lines 8332 8332 ==========================================
- Hits 6004 6002 -2 - Misses 1926 1927 +1 - Partials 402 403 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Statically including the file with name that has a colon in it is invalid for Go modules, which lead to the v1.5.0 release being rendered broken: The go mod error shows: - malformed file path "...local:5000/hosts.toml": invalid char ':' - This prevents the module from being downloaded and verified - Finally, the Go sum database returns 404 because it can't process this malformed module This commit creates the file dynamically, instead of including the file statically in the repository. Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
2458686 to
3670078Compare| # Wait for registry to be available if it exists (for e2e tests) | ||
| if kubectl get namespace operator-controller-e2e >/dev/null 2>&1; then | ||
| echo "Waiting for e2e registry to be available..." | ||
| if ! kubectl_wait "operator-controller-e2e" "deployment/docker-registry" "60s"; then | ||
| echo "Error: E2E registry is not ready, cannot proceed with deployment" | ||
| exit 1 | ||
| fi | ||
| fi | ||
There was a problem hiding this comment.
The upgrade-experimental-e2e is failing because this check is not present in the lastest release.
Hopefully 60s of wait time will be enough.
tmshort
commented
Sep 9, 2025
We ought to pick one, this, or #2202 |
anik120
commented
Sep 9, 2025
Closing this in favor of #2202 |
Statically including the file with name that has a colon in it is invalid for Go modules, which lead to the v1.5.0 release being rendered broken:
The go mod error shows:
This commit creates the file dynamically, instead of including the file statically in the repository.
Description
Reviewer Checklist