Skip to content

🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module - #2202

Merged
anik120 merged 3 commits into
operator-framework:mainfrom
joelanford:fix-go-mod-zip
Sep 9, 2025
Merged

🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module#2202
anik120 merged 3 commits into
operator-framework:mainfrom
joelanford:fix-go-mod-zip

Conversation

@joelanford

@joelanfordjoelanford commented Sep 9, 2025

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford
joelanford requested a review from a team as a code ownerSeptember 9, 2025 02:00
@netlify

netlifyBot commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit068b71b
🔍 Latest deploy loghttps://app.netlify.com/projects/olmv1/deploys/68c09d111e50b80009cdbf31
😎 Deploy Previewhttps://deploy-preview-2202--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

tmshort commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Per the errors in the CI, he empty go.mod may still require a package name.

anik120
anik120 reviewed Sep 9, 2025
View reviewed changes

@anik120anik120 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can just retract the v1.5.0 and we can dynamically create the containerd config #2203

@tmshort

tmshort commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

We ought to pick one, this, or #2203

@tmshorttmshort mentioned this pull request Sep 9, 2025
Closed
4 tasks
@codecov

codecovBot commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.12%. Comparing base (68610d0) to head (068b71b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #2202 +/- ##
==========================================
+ Coverage 72.05% 72.12% +0.06% 
==========================================
Files 85 85 Lines 8332 8401 +69 ==========================================
+ Hits 6004 6059 +55 - Misses 1926 1939 +13 - Partials 402 403 +1
FlagCoverage Δ
e2e39.47% <ø> (+0.01%)⬆️
experimental-e2e46.26% <ø> (+0.02%)⬆️
unit56.85% <ø> (+0.18%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d fr…
068b71b
…om root module
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ciBot commented Sep 9, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@anik120

anik120 commented Sep 9, 2025

Copy link
Copy Markdown
Member

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@anik120
anik120 merged commit 67098e7 into operator-framework:mainSep 9, 2025
21 of 23 checks passed
@joelanford
joelanford deleted the fix-go-mod-zip branch September 10, 2025 12:55
joelanford added a commit to joelanford/operator-controller that referenced this pull request Sep 10, 2025
@joelanford@tmshort
🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from ro…
72b80aa
…ot module (operator-framework#2202)
* retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
Signed-off-by: Todd Short <tshort@redhat.com>
---------
Signed-off-by: Todd Short <tshort@redhat.com>
Co-authored-by: Todd Short <tshort@redhat.com>
@joelanfordjoelanford mentioned this pull request Sep 10, 2025
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtfranzdtfranzAwaiting requested review from dtfranz
@OchiengEdOchiengEdAwaiting requested review from OchiengEd
1 more reviewer
@anik120anik120anik120 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@anik120anik120

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joelanford@tmshort@anik120