Skip to content

🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module [release-v1.5] - #2206

Merged
joelanford merged 1 commit into
operator-framework:release-v1.5from
joelanford:backport-go-mod-fix-colon
Sep 10, 2025
Merged

🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module [release-v1.5]#2206
joelanford merged 1 commit into
operator-framework:release-v1.5from
joelanford:backport-go-mod-fix-colon

Conversation

@joelanford

@joelanfordjoelanford commented Sep 10, 2025•
edited by tmshort
Loading

Copy link
Copy Markdown
Member

Back port of #2202

  • retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

  • fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

  • fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford@tmshort
🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from ro…
72b80aa
…ot module (operator-framework#2202)
* retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
* fixup! retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module
Signed-off-by: Todd Short <tshort@redhat.com>
---------
Signed-off-by: Todd Short <tshort@redhat.com>
Co-authored-by: Todd Short <tshort@redhat.com>
@joelanford
joelanford requested a review from a team as a code ownerSeptember 10, 2025 14:24
@tmshort

tmshort commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@openshift-ci

openshift-ciBot commented Sep 10, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@tmshorttmshort changed the title 🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from ro…🐛 retract v1.5.0; exclude hack/kind-config/containerd/certs.d from root module [release-v1.5]Sep 10, 2025
@joelanford

joelanford commented Sep 10, 2025

Copy link
Copy Markdown
MemberAuthor

/override upgrade-experimental-e2e

@openshift-ci

openshift-ciBot commented Sep 10, 2025

Copy link
Copy Markdown

@joelanford: Overrode contexts on behalf of joelanford: upgrade-experimental-e2e

Details

In response to this:

/override upgrade-experimental-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecovBot commented Sep 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.80%. Comparing base (b4aeb92) to head (72b80aa).
⚠️ Report is 1 commits behind head on release-v1.5.

Additional details and impacted files
@@ Coverage Diff @@## release-v1.5 #2206 +/- ##
================================================
- Coverage 72.84% 72.80% -0.05% 
================================================
Files 79 79 Lines 7421 7421 ================================================
- Hits 5406 5403 -3 - Misses 1667 1669 +2 - Partials 348 349 +1
FlagCoverage Δ
e2e44.19% <ø> (-0.05%)⬇️
experimental-e2e56.13% <ø> (+0.04%)⬆️
unit58.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelanford
joelanford merged commit 6b277d1 into operator-framework:release-v1.5Sep 10, 2025
18 of 20 checks passed
@joelanford
joelanford deleted the backport-go-mod-fix-colon branch September 10, 2025 14:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80oceanc80Awaiting requested review from oceanc80
@rashmigottipatirashmigottipatiAwaiting requested review from rashmigottipati

Assignees

@tmshorttmshort

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joelanford@tmshort