Uh oh!
There was an error while loading. Please reload this page.
fix: do not include channel name or priority in bundle sorting during resolution - #420
Merged
joelanford merged 1 commit intoSep 21, 2023
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@## main #420 +/- ##
=======================================
Coverage 84.42% 84.42% =======================================
Files 23 23 Lines 777 777 =======================================
Hits 656 656 Misses 86 86 Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
marked this pull request as draft
September 20, 2023 03:55
joelanfordforce-pushed
the
fix-bundle-sorting
branch
from
September 21, 2023 12:43
6c9ca25 to
4a90ef7Comparejoelanford
marked this pull request as ready for review
September 21, 2023 12:44
… sorting during resolution Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanfordforce-pushed
the
fix-bundle-sorting
branch
from
September 21, 2023 13:26
4a90ef7 to
c45fb33Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#413 fixed the bug described in #419
This PR updates tests to ensure there are no regressions.
Reviewer Checklist