Skip to content

Remove offline resolution CLI variable source - #495

Merged
stevekuznetsov merged 1 commit into
operator-framework:mainfrom
m1kola:remove_offline_resolution_variable_source
Nov 1, 2023
Merged

Remove offline resolution CLI variable source#495
stevekuznetsov merged 1 commit into
operator-framework:mainfrom
m1kola:remove_offline_resolution_variable_source

Conversation

@m1kola

@m1kolam1kola commented Oct 31, 2023

Copy link
Copy Markdown
Member

Description

Spliting #460 into smaller chunks. Related to #437

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
@codecov

codecovBot commented Oct 31, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7156464) 83.75% compared to head (432c2f7) 83.75%.

Additional details and impacted files
@@ Coverage Diff @@## main #495 +/- ##
=======================================
Coverage 83.75% 83.75% =======================================
Files 23 23 Lines 868 868 =======================================
Hits 727 727 Misses 96 96 Partials 45 45
FlagCoverage Δ
e2e65.09% <ø> (ø)
unit78.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kola marked this pull request as ready for review October 31, 2023 14:23
@m1kola
m1kola requested a review from a team as a code ownerOctober 31, 2023 14:23
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
Closed
stevekuznetsov
stevekuznetsov reviewed Oct 31, 2023
View reviewed changes
Comment threadcmd/resolutioncli/main.go Outdated
stevekuznetsov
stevekuznetsov reviewed Oct 31, 2023
View reviewed changes
Comment threadcmd/resolutioncli/main.go
"fmt"
"os"

"github.com/operator-framework/deppy/pkg/deppy/solver"

@stevekuznetsovstevekuznetsovOct 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: likely good to use an import sorting linter to remove these diffs in the future

Mikalai Radchuk
Remove offline resolution CLI variable source
432c2f7
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the remove_offline_resolution_variable_source branch from fd9e75d to 432c2f7CompareOctober 31, 2023 17:11
@m1kola

m1kola commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

@stevekuznetsov I see that you enabled auto merge yesterday. Did you also mean to approve it? Or do you have further feedback?

@stevekuznetsov

stevekuznetsov commented Nov 1, 2023

Copy link
Copy Markdown

Sorry, all the repos have different rules for merging and it's too easy to do the wrong dance ...

stevekuznetsov
stevekuznetsov approved these changes Nov 1, 2023
View reviewed changes

@stevekuznetsovstevekuznetsov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d

@stevekuznetsov
stevekuznetsov added this pull request to the merge queue Nov 1, 2023
@m1kola

m1kola commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

Sorry, all the repos have different rules for merging and it's too easy to do the wrong dance ...

No worries! Thanks for the update!

Merged via the queue into operator-framework:main with commit 7411e68Nov 1, 2023
@m1kola
m1kola deleted the remove_offline_resolution_variable_source branch November 6, 2023 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@stevekuznetsovstevekuznetsovstevekuznetsov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola@stevekuznetsov