Skip to content

Move data fetching to a single place - #508

Merged
ncdc merged 1 commit into
operator-framework:mainfrom
m1kola:single_data_fetching
Nov 3, 2023
Merged

Move data fetching to a single place#508
ncdc merged 1 commit into
operator-framework:mainfrom
m1kola:single_data_fetching

Conversation

@m1kola

Copy link
Copy Markdown
Member

Description

Closes#418

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the single_data_fetching branch from b7d778c to 2cf102fCompareNovember 3, 2023 11:29
@codecov

codecovBot commented Nov 3, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9081f96) 83.69% compared to head (2cf102f) 84.11%.

Additional details and impacted files
@@ Coverage Diff @@## main #508 +/- ##
==========================================
+ Coverage 83.69% 84.11% +0.41% 
==========================================
Files 23 23 Lines 877 875 -2 ==========================================
+ Hits 734 736 +2 + Misses 97 95 -2 + Partials 46 44 -2 
FlagCoverage Δ
e2e65.82% <82.35%> (+0.60%)⬆️
unit78.87% <82.35%> (+0.19%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
...al/resolution/variablesources/bundle_deployment.go78.94% <100.00%> (+6.22%)⬆️
...lution/variablesources/bundles_and_dependencies.go100.00% <100.00%> (+4.00%)⬆️
...al/resolution/variablesources/installed_package.go73.91% <100.00%> (+2.48%)⬆️
internal/resolution/variablesources/operator.go88.88% <100.00%> (+7.93%)⬆️
...nal/resolution/variablesources/required_package.go72.50% <100.00%> (-1.92%)⬇️
internal/controllers/variable_source.go72.72% <64.70%> (-27.28%)⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kola marked this pull request as ready for review November 3, 2023 11:46
@m1kola
m1kola requested a review from a team as a code ownerNovember 3, 2023 11:46
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kola
m1kola enabled auto-merge November 3, 2023 11:46
ncdc
ncdc approved these changes Nov 3, 2023
@m1kola
m1kola added this pull request to the merge queue Nov 3, 2023
Comment threadinternal/controllers/variable_source.go
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Nov 3, 2023
@ncdc
ncdc added this pull request to the merge queue Nov 3, 2023
Merged via the queue into operator-framework:main with commit 2c3176dNov 3, 2023
@m1kola
m1kola deleted the single_data_fetching branch November 3, 2023 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve resolution efficiency

3 participants

@m1kola@ncdc@stevekuznetsov