Skip to content

Part 2: Reduce number of variable sources. Bundle variables. - #498

Merged
m1kola merged 2 commits into
operator-framework:mainfrom
m1kola:shrink_variable_sources_p2
Nov 3, 2023
Merged

Part 2: Reduce number of variable sources. Bundle variables.#498
m1kola merged 2 commits into
operator-framework:mainfrom
m1kola:shrink_variable_sources_p2

Conversation

@m1kola

@m1kolam1kola commented Oct 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

Spliting #460 into smaller chunks. Related to #437

In this part I extract code related to creating bundle variables from BundlesAndDepsVariableSource into a separate function.

BundlesAndDepsVariableSource will be removed later in #501

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2023
This was referenced Oct 31, 2023
Merged
Merged
Merged
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch from 0c38e67 to 4f9d453CompareOctober 31, 2023 16:35
@m1kolam1kola mentioned this pull request Oct 31, 2023
Closed
4 tasks
@m1kolam1kola changed the title Part 2: Reduce number of variable sourcesPart 2: Reduce number of variable sources. Bundle variables.Oct 31, 2023
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch from 4f9d453 to e4a1377CompareNovember 1, 2023 16:13
@codecov

codecovBot commented Nov 1, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c3176d) 84.11% compared to head (8ecced7) 84.41%.

Additional details and impacted files
@@ Coverage Diff @@## main #498 +/- ##
==========================================
+ Coverage 84.11% 84.41% +0.30% 
==========================================
Files 23 23 Lines 875 892 +17 ==========================================
+ Hits 736 753 +17 
Misses 95 95 Partials 44 44
FlagCoverage Δ
e2e65.91% <70.37%> (+0.09%)⬆️
unit79.54% <96.29%> (+0.66%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
internal/resolution/variablesources/bundle.go100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

m1kola
m1kola commented Nov 1, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch 5 times, most recently from 8d2811d to c9a1ea5CompareNovember 2, 2023 11:27
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
joelanford
joelanford reviewed Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
m1kola
m1kola commented Nov 2, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch 3 times, most recently from 05bd2d7 to 237206aCompareNovember 2, 2023 16:29
@m1kolam1kola mentioned this pull request Nov 2, 2023
Closed
8 tasks
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch from 237206a to d92550dCompareNovember 2, 2023 17:07
@m1kola
m1kola marked this pull request as ready for review November 2, 2023 17:09
@m1kola
m1kola requested a review from a team as a code ownerNovember 2, 2023 17:09
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@m1kola

m1kola commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@joelanford please take another look. I believe I addressed all your feedback.

@m1kolam1kola mentioned this pull request Nov 3, 2023
Closed
stevekuznetsov
stevekuznetsov reviewed Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
stevekuznetsov
stevekuznetsov reviewed Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go
stevekuznetsov
stevekuznetsov reviewed Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
stevekuznetsov
stevekuznetsov reviewed Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
m1kola
m1kola commented Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle_test.go Outdated
@m1kolam1kola mentioned this pull request Nov 3, 2023
Merged
4 tasks
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch from d92550d to 3070b48CompareNovember 3, 2023 14:23
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kola

m1kola commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

Moveing back to draft for now becuase it needs a bit more work after #508 + address feedback.

@m1kola
m1kola marked this pull request as draft November 3, 2023 14:24
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
Mikalai Radchuk added 2 commits November 3, 2023 14:28
Mikalai Radchuk
Move files
86bf448
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Mikalai Radchuk
Move bundle variable code into a func
8ecced7
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the shrink_variable_sources_p2 branch from 3070b48 to 8ecced7CompareNovember 3, 2023 14:57
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kola
m1kola marked this pull request as ready for review November 3, 2023 15:09
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kola

m1kola commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

@stevekuznetsov@joelanford rebased on top of #508 + addressed feedback. Please take another look

@m1kola
m1kola added this pull request to the merge queue Nov 3, 2023
Merged via the queue into operator-framework:main with commit 36cd3c8Nov 3, 2023
@m1kola
m1kola deleted the shrink_variable_sources_p2 branch November 6, 2023 10:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordAwaiting requested review from joelanford
1 more reviewer
@stevekuznetsovstevekuznetsovstevekuznetsov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m1kola@joelanford@stevekuznetsov@openshift-merge-robot