Skip to content

🌱 Improve error message about missing bundles - #509

Merged
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:improve_error_message
Nov 6, 2023
Merged

🌱 Improve error message about missing bundles#509
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:improve_error_message

Conversation

@m1kola

@m1kolam1kola commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

Follow up for #498 (comment)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@m1kolam1kola mentioned this pull request Nov 3, 2023
Merged
4 tasks
@m1kola
m1kolaforce-pushed the improve_error_message branch from 3157925 to b83d5abCompareNovember 3, 2023 16:32
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
m1kola
m1kola commented Nov 3, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
@m1kola
m1kola marked this pull request as ready for review November 3, 2023 16:35
@m1kola
m1kola requested a review from a team as a code ownerNovember 3, 2023 16:35
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@m1kolam1kola changed the title Improve error message about missing bundlesImprove error messageImprove error message about missing bundlesNov 3, 2023
@codecov

codecovBot commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aca6451) 84.41% compared to head (97aa4d1) 84.19%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #509 +/- ##
==========================================
- Coverage 84.41% 84.19% -0.23% 
==========================================
Files 23 23 Lines 892 892 ==========================================
- Hits 753 751 -2 - Misses 95 96 +1 - Partials 44 45 +1
FlagCoverage Δ
e2e65.69% <0.00%> (-0.23%)⬇️
unit79.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
internal/resolution/variablesources/bundle.go100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kolaforce-pushed the improve_error_message branch from b83d5ab to 2fed553CompareNovember 6, 2023 09:38
joelanford
joelanford reviewed Nov 6, 2023
View reviewed changes
Comment threadinternal/resolution/variablesources/bundle.go Outdated
Mikalai Radchuk
Improve error message about missing bundles
97aa4d1
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the improve_error_message branch from 2fed553 to 97aa4d1CompareNovember 6, 2023 15:03
everettraven
everettraven approved these changes Nov 6, 2023
View reviewed changes

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncdcncdc changed the title Improve error message about missing bundles🌱 Improve error message about missing bundlesNov 6, 2023
@m1kola
m1kola added this pull request to the merge queue Nov 6, 2023
Merged via the queue into operator-framework:main with commit 69db2adNov 6, 2023
@m1kola
m1kola deleted the improve_error_message branch November 7, 2023 15:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordAwaiting requested review from joelanford
1 more reviewer
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m1kola@joelanford@everettraven@openshift-merge-robot