Skip to content

🌱 GitHub Actions: Setup kind cluster without ctlptl - #777

Merged
everettraven merged 1 commit into
operator-framework:mainfrom
m1kola:tilt_ci_kind_setup
Apr 23, 2024
Merged

🌱 GitHub Actions: Setup kind cluster without ctlptl#777
everettraven merged 1 commit into
operator-framework:mainfrom
m1kola:tilt_ci_kind_setup

Conversation

@m1kola

Copy link
Copy Markdown
Member

Description

We already have kind cluster setup scripted in Makefile which includes correct configuration.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@m1kola
m1kola requested a review from a team as a code ownerApril 23, 2024 09:31
@netlify

netlifyBot commented Apr 23, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit5e840e9
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6627802e6098980008e731dd
😎 Deploy Previewhttps://deploy-preview-777--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kolam1kola changed the title 🌱 Setup kind cluster witohut ctlptl🌱 Setup kind cluster without ctlptlApr 23, 2024
We already have kind cluster setup scripted in `Makefile`
which includes correct configuration.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
m1kolaforce-pushed the tilt_ci_kind_setup branch from 389c35e to 5e840e9CompareApril 23, 2024 09:32
@codecov

codecovBot commented Apr 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (0c41e3e) to head (5e840e9).

Additional details and impacted files
@@ Coverage Diff @@## main #777 +/- ##
=======================================
Coverage 67.16% 67.16% =======================================
Files 22 22 Lines 1465 1465 =======================================
Hits 984 984 Misses 415 415 Partials 66 66 
FlagCoverage Δ
e2e45.46% <ø> (ø)
unit61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kolam1kola changed the title 🌱 Setup kind cluster without ctlptl🌱 GitHub Actions: Setup kind cluster without ctlptlApr 23, 2024
@joelanford

Copy link
Copy Markdown
Member

I recall there being a specific reason for using ctlptl. It may have been the ease of getting an image registry setup to test pulling private catalog images.

On the other hand, all the tests are passing with this change, so 🤷‍♂️

@everettraven May have more specific knowledge.

@tmshort

Copy link
Copy Markdown
Contributor

This job (tilt) appears to be failing in #774... but do we really need to change the tilt code, or is it something about that PR?

@m1kola

Copy link
Copy Markdown
MemberAuthor

@tmshort this PR will fix tilt for #774. The reason for the failure is that ctlptl creates a kind cluster with default config, but we need a custom config to enable beta APIs. I added a kind config in #771 but I missed ctlptl: I made an assumption that all clusters in CI are being created with our Makefile targets.

@m1kola

Copy link
Copy Markdown
MemberAuthor

I recall there being a specific reason for using ctlptl. It may have been the ease of getting an image registry setup to test pulling private catalog images.

We discussed this in upstream slack here. I think this was related to e2e jobs. I don't think the tilt job is actually testing anything beyond being able to build and deploy the binaries with tilt. It does not use registry with test bundle images as far as I understand.

@everettraven
everettraven added this pull request to the merge queue Apr 23, 2024
Merged via the queue into operator-framework:main with commit ebd95a8Apr 23, 2024
@m1kola
m1kola deleted the tilt_ci_kind_setup branch April 23, 2024 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@m1kola@joelanford@tmshort@everettraven