Uh oh!
There was an error while loading. Please reload this page.
✨ Add ValidatingAdmissionPolicy to enforce package uniqueness across ClusterExtension - #774
Merged
grokspawn merged 2 commits intoApr 24, 2024
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m1kola
commented
Apr 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #774 +/- ##
=======================================
Coverage 67.16% 67.16% =======================================
Files 22 22 Lines 1465 1465 =======================================
Hits 984 984 Misses 415 415 Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kolaforce-pushed
the
add_ValidatingAdmissionPolicy
branch
from
April 22, 2024 14:58
f17ff5e to
55eab3eComparem1kola
commented
Apr 22, 2024
MemberAuthor
Keeping this in draft for now. It seems like tilt job needs to be updated in addition to #771 |
m1kolaforce-pushed
the
add_ValidatingAdmissionPolicy
branch
3 times, most recently
from
April 23, 2024 10:23
5d45189 to
6537533Comparem1kola
commented
Apr 23, 2024
Uh oh!
There was an error while loading. Please reload this page.
m1kola
commented
Apr 23, 2024
Uh oh!
There was an error while loading. Please reload this page.
m1kolaforce-pushed
the
add_ValidatingAdmissionPolicy
branch
2 times, most recently
from
April 23, 2024 12:45
0951051 to
4cadf14Compare4 tasks
added 2 commits
April 23, 2024 16:03
To enforce package uniqueness across `ClusterExtension` Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
This is a workaround for kustomize issue where it does not prefix `ValidatingAdmissionPolicy`'s name in `ValidatingAdmissionPolicyBinding`'s field `spec.policyName`. This results in manifests which can still be applied to a cluster, but the policy will not be working due to broken policy binding. These APIs are now stable in 1.30 so one might expect that Kustomize will eventually support these by default. If this happens - we will be able to remove this change. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kolaforce-pushed
the
add_ValidatingAdmissionPolicy
branch
from
April 23, 2024 14:18
4cadf14 to
e59ab41Comparem1kola
marked this pull request as ready for review
April 23, 2024 14:27
joelanford
approved these changes
Apr 24, 2024
joelanford
left a comment
Member
There was a problem hiding this comment.
Looks great!
In a follow-up, could we add some tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To enforce package uniqueness across
ClusterExtension.We currently have this enforcement on the operator-controller level, but with Deppy removal in #758 we want to shift it into API server.
Reviewer Checklist