Uh oh!
There was an error while loading. Please reload this page.
🌱 Add ClusterExtension package uniqueness test - #785
Merged
Conversation
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m1kola
commented
Apr 25, 2024
| ocv1alpha1 "github.com/operator-framework/operator-controller/api/v1alpha1" | ||
| ) | ||
| func TestClusterExtensionPackageUniqueness(t *testing.T) { |
MemberAuthor
There was a problem hiding this comment.
Feels a bit like we are testing upstream Kubernetes... Is this test worth having?
MemberAuthor
There was a problem hiding this comment.
On the other hand - I got CEL expression wrong at first while working on #774: I blocked edits :) Given that I think it makes sense.
m1kola
marked this pull request as ready for review
April 25, 2024 15:08
tmshort
commented
Apr 25, 2024
Contributor
/approve |
tmshort
enabled auto-merge
April 25, 2024 17:45
tmshort
approved these changes
Apr 25, 2024
m1kola
commented
Apr 26, 2024
MemberAuthor
I think I introduced a flake here. Example. I'll look into it. |
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #774
Reviewer Checklist