Skip to content

⚠️ Bump rukpak - #905

Merged
m1kola merged 17 commits into
operator-framework:mainfrom
varshaprasad96:bump/rukpak
Jun 12, 2024
Merged

⚠️ Bump rukpak#905
m1kola merged 17 commits into
operator-framework:mainfrom
varshaprasad96:bump/rukpak

Conversation

@varshaprasad96

@varshaprasad96varshaprasad96 commented Jun 3, 2024

Copy link
Copy Markdown
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2024
@netlify

netlifyBot commented Jun 3, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit6bc072f
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/6668682982c3820008340f1b
😎 Deploy Previewhttps://deploy-preview-905--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dtfranz
dtfranz reviewed Jun 3, 2024
View reviewed changes
Comment threadDockerfile
dtfranz
dtfranz reviewed Jun 3, 2024
View reviewed changes
Comment threadMakefile
@codecov

codecovBot commented Jun 4, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (40e1bac) to head (6bc072f).
Report is 1 commits behind head on main.

FilesPatch %Lines
cmd/manager/main.go30.00%4 Missing and 3 partials ⚠️
...nternal/controllers/clusterextension_controller.go66.66%3 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #905 +/- ##
==========================================
+ Coverage 73.54% 77.38% +3.83% 
==========================================
Files 18 17 -1 Lines 1221 1163 -58 ==========================================
+ Hits 898 900 +2 + Misses 248 183 -65 - Partials 75 80 +5
FlagCoverage Δ
e2e57.17% <44.00%> (-3.02%)⬇️
unit50.98% <24.00%> (+2.74%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bentito
bentito reviewed Jun 4, 2024
View reviewed changes
Comment threadtestdata/bundles/registry-v1/package-with-webhooks.v1.0.0/Dockerfile Outdated
bentito
bentito reviewed Jun 4, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_controller.go Outdated
dtfranz
dtfranz reviewed Jun 4, 2024
View reviewed changes
Comment threadtestdata/catalogs/test-catalog/catalog.yaml Outdated
@tmshorttmshort mentioned this pull request Jun 4, 2024
Closed
4 tasks
tmshort
tmshort reviewed Jun 5, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_controller.go
@tmshorttmshort mentioned this pull request Jun 5, 2024
Merged
4 tasks
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2024
@varshaprasad96
varshaprasad96force-pushed the bump/rukpak branch 3 times, most recently from 32e223d to 9cae5f3CompareJune 6, 2024 15:50
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
@varshaprasad96varshaprasad96 mentioned this pull request Jun 7, 2024
Closed
11 tasks
varshaprasad96and others added 8 commits June 7, 2024 14:54
@varshaprasad96@tmshort
Bump rukpak
e2a779a
@varshaprasad96@tmshort
debugging tests
5652656
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Use tar for manifests
6a671e8
Signed-off-by: Todd Short <tshort@redhat.com>
@varshaprasad96@tmshort
fix e2e
9a939bc
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Remove unpack
9724c1d
Signed-off-by: Todd Short <tshort@redhat.com>
@varshaprasad96@tmshort
rebase with main
96ffa18
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@tmshort
Fix webhooks package name and remove unstructured
9a10bb3
Make the webhooks package name consistent with oterhs
Revert the use of unstructured
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
ext-dev-e2e passes
6e398b1
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshorttmshort changed the title Bump rukpak⚠️ Bump rukpakJun 7, 2024
@varshaprasad96
Add annotation to set insecureSkipTLSVerify
1ed0f20
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@m1kolam1kola mentioned this pull request Jun 11, 2024
Merged
4 tasks
m1kola
m1kola reviewed Jun 11, 2024
View reviewed changes

@m1kolam1kola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some comment threads which are open. Apart from that - looks good to me.

@tmshort
Rename back to package-with-webhooks
5097525
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
Used labeled rukpak
f9cca2a
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Made a couple (small) commits to hopefully address the last of the comments... @m1kola ?

@varshaprasad96
Fix error message for unknown unpack state
6bc072f
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@varshaprasad96

varshaprasad96 commented Jun 11, 2024

Copy link
Copy Markdown
MemberAuthor

@m1kola looks like all the comments have been addressed. Could you please provide a lgtm if all is well.

@tmshort
tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort
tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort
tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@tmshort

tmshort commented Jun 11, 2024

Copy link
Copy Markdown
Contributor
GitHub Actions has encountered an internal error when running your job.

@tmshort
tmshort added this pull request to the merge queue Jun 11, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jun 11, 2024
@m1kola
m1kola added this pull request to the merge queue Jun 12, 2024
Merged via the queue into operator-framework:main with commit 66a063bJun 12, 2024
@tmshorttmshort mentioned this pull request Jun 13, 2024
Closed
@tmshorttmshort mentioned this pull request Jun 27, 2024
Closed
This was referenced Jul 2, 2024
Merged
Closed
Merged
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordjoelanford left review comments
@dtfranzdtfranzdtfranz left review comments
@tmshorttmshorttmshort left review comments
+3 more reviewers
@bentitobentitobentito left review comments
@m1kolam1kolam1kola approved these changes
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@varshaprasad96@m1kola@tmshort@joelanford@bentito@dtfranz@everettraven@openshift-merge-robot