Uh oh!
There was an error while loading. Please reload this page.
✨ Update status update functions - #908
Merged
Merged
Conversation
Remove references to rukpak k8s API where possible. With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #908 +/- ##
==========================================
- Coverage 77.93% 77.77% -0.16%
==========================================
Files 17 17 Lines 1142 1152 +10 ==========================================
+ Hits 890 896 +6 - Misses 175 179 +4
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
bentito
commented
Jun 5, 2024
Contributor
/lgtm /approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to rukpak k8s API where possible.
With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures
This also makes the update functions consistent signature/behavior.
Description
Reviewer Checklist