Skip to content

✨ Cleanups after bumping Rukpak - #928

Merged
varshaprasad96 merged 1 commit into
operator-framework:mainfrom
varshaprasad96:cleanups
Jun 13, 2024
Merged

✨ Cleanups after bumping Rukpak#928
varshaprasad96 merged 1 commit into
operator-framework:mainfrom
varshaprasad96:cleanups

Conversation

@varshaprasad96

@varshaprasad96varshaprasad96 commented Jun 12, 2024

Copy link
Copy Markdown
Member

This PR makes the following changes:

  1. Removes the use of a separate handler, given rukpak has now externalized its implementation.
  2. Removes the unpacking status, which is no longer required with the use of direct registry client.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@varshaprasad96
varshaprasad96 requested a review from a team as a code ownerJune 12, 2024 17:42
@netlify

netlifyBot commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit3fa711f
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/666a9573adc35f00087257fb
😎 Deploy Previewhttps://deploy-preview-928--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (543dc15) to head (3fa711f).

Additional details and impacted files
@@ Coverage Diff @@## main #928 +/- ##
==========================================
+ Coverage 77.45% 79.15% +1.70% 
==========================================
Files 17 15 -2 Lines 1153 1084 -69 ==========================================
- Hits 893 858 -35 + Misses 181 157 -24 + Partials 79 69 -10
FlagCoverage Δ
e2e57.19% <100.00%> (+0.38%)⬆️
unit54.70% <33.33%> (+3.27%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

varshaprasad96
varshaprasad96 commented Jun 12, 2024
View reviewed changes
Comment threadapi/v1alpha1/clusterextension_types.go
joelanford
joelanford previously approved these changes Jun 12, 2024
View reviewed changes
@joelanfordjoelanford mentioned this pull request Jun 12, 2024
Closed
4 tasks
@varshaprasad96
varshaprasad96 added this pull request to the merge queue Jun 12, 2024
@varshaprasad96
varshaprasad96 removed this pull request from the merge queue due to a manual request Jun 12, 2024
@varshaprasad96
varshaprasad96 added this pull request to the merge queue Jun 12, 2024
@varshaprasad96
varshaprasad96 removed this pull request from the merge queue due to a manual request Jun 12, 2024
@varshaprasad96

varshaprasad96 commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

Looks like #916 is causing merge conflicts when added to the queue. Will rebase this after #916 gets merged.

@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2024
@varshaprasad96
Clean ups after bumping Rukapk
3fa711f
This PR makes the following changes:
1. Removes the use of a separate handler, given rukpak has
now externalized its implementation.
2. Removes the unpacking status, which is no longer required with
the use of direct registry client.
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2024
@bentitobentito changed the title ✨ Clean ups after bumping Rukapk✨ Clean ups after bumping RukpakJun 13, 2024
@bentitobentito changed the title ✨ Clean ups after bumping Rukpak✨ Cleanups after bumping RukpakJun 13, 2024
bentito
bentito reviewed Jun 13, 2024
View reviewed changes
Comment threadinternal/controllers/clusterextension_controller.go
bentito
bentito reviewed Jun 13, 2024
View reviewed changes
Comment threadinternal/controllers/common_controller.go
bentito
bentito reviewed Jun 13, 2024
View reviewed changes
Comment threadapi/v1alpha1/clusterextension_types.go
bentito
bentito reviewed Jun 13, 2024
View reviewed changes
Comment threadapi/v1alpha1/clusterextension_types.go
@varshaprasad96varshaprasad96 mentioned this pull request Jun 13, 2024
Closed
@bentito

bentito commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@varshaprasad96
varshaprasad96 added this pull request to the merge queue Jun 13, 2024
everettraven
everettraven approved these changes Jun 13, 2024
View reviewed changes

@everettraveneverettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and seems reasonable to have #929 as a follow up.

Merged via the queue into operator-framework:main with commit 8041cc4Jun 13, 2024
This was referenced Jun 14, 2024
Closed
Closed
This was referenced Jul 2, 2024
Merged
Closed
Merged
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanfordjoelanfordjoelanford approved these changes
+2 more reviewers
@bentitobentitobentito left review comments
@everettraveneverettraveneverettraven approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bentitobentito

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@varshaprasad96@bentito@joelanford@everettraven@openshift-merge-robot