Skip to content

✨ Use apimachinery sets instead of maps - #933

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
itroyano:apimachinery-sets
Jun 13, 2024
Merged

✨ Use apimachinery sets instead of maps#933
tmshort merged 1 commit into
operator-framework:mainfrom
itroyano:apimachinery-sets

Conversation

@itroyano

@itroyanoitroyano commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes#881

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@itroyano
use apimachinery.sets instead of maps
2e2e85e
Signed-off-by: Igor Troyanovsky <itroyano@redhat.com>
@itroyano
itroyano requested a review from a team as a code ownerJune 13, 2024 17:57
@itroyano
itroyano marked this pull request as draft June 13, 2024 17:57
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@netlify

netlifyBot commented Jun 13, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit2e2e85e
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/666b33004250f100083d70da
😎 Deploy Previewhttps://deploy-preview-933--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jun 13, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (8041cc4) to head (2e2e85e).

Additional details and impacted files
@@ Coverage Diff @@## main #933 +/- ##
==========================================
+ Coverage 79.15% 79.61% +0.46% 
==========================================
Files 15 15 Lines 1084 1084 ==========================================
+ Hits 858 863 +5 + Misses 157 154 -3 + Partials 69 67 -2
FlagCoverage Δ
e2e57.65% <100.00%> (+0.46%)⬆️
unit54.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itroyano
itroyano marked this pull request as ready for review June 13, 2024 18:29
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
tmshort
tmshort approved these changes Jun 13, 2024
View reviewed changes

@tmshorttmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@tmshort
tmshort added this pull request to the merge queue Jun 13, 2024
Merged via the queue into operator-framework:main with commit 5798a4aJun 13, 2024
This was referenced Jul 2, 2024
Merged
Closed
Merged
@skattojuskattoju mentioned this pull request Sep 9, 2024
Merged
@skattojuskattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmshorttmshorttmshort approved these changes

Assignees

@tmshorttmshort

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use k8s.io/apimachinery/pkg/util/sets package

2 participants

@itroyano@tmshort