Skip to content

🌱 Remove kind config - #936

Merged
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:remove_kind_config
Jun 14, 2024
Merged

🌱 Remove kind config#936
m1kola merged 1 commit into
operator-framework:mainfrom
m1kola:remove_kind_config

Conversation

@m1kola

Copy link
Copy Markdown
Member

Description

We no longer need to enable ValidatingAdmissionPolicy since it is enabled by default in K8s 1.30.
This means we can delete kind-config.yaml.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

We no longer need to enable `ValidatingAdmissionPolicy` since
it is enabled by default in K8s 1.30.
This means we can delete `kind-config.yaml`.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@netlify

netlifyBot commented Jun 14, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit8758cc8
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/666c4adfb27acd00085448d6
😎 Deploy Previewhttps://deploy-preview-936--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jun 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.34%. Comparing base (edc91ad) to head (8758cc8).

Additional details and impacted files
@@ Coverage Diff @@## main #936 +/- ##
=======================================
Coverage 79.34% 79.34% =======================================
Files 16 16 Lines 1104 1104 =======================================
Hits 876 876 Misses 158 158 Partials 70 70 
FlagCoverage Δ
e2e58.15% <ø> (ø)
unit53.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola
m1kola marked this pull request as ready for review June 14, 2024 14:03
@m1kola
m1kola requested a review from a team as a code ownerJune 14, 2024 14:03
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@m1kola
m1kola added this pull request to the merge queue Jun 14, 2024
Merged via the queue into operator-framework:main with commit 27602adJun 14, 2024
@m1kola
m1kola deleted the remove_kind_config branch June 14, 2024 14:54
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola@grokspawn