Uh oh!
There was an error while loading. Please reload this page.
🐛 Fix rbac generation in Makefile - #937
Conversation
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trgeiger
commented
Jun 14, 2024
Thanks for catching this, LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #937 +/- ##
==========================================
- Coverage 79.34% 79.16% -0.19%
==========================================
Files 16 16 Lines 1104 1104 ==========================================
- Hits 876 874 -2 - Misses 158 159 +1 - Partials 70 71 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grokspawn
commented
Jun 14, 2024
should we also .gitignore config/rbac since it is generated? |
m1kola
commented
Jun 14, 2024
@grokspawn nothing should write into |
varshaprasad96
left a comment
There was a problem hiding this comment.
Agree with @m1kola. We aren't adding other generated files to gitignore, and should keep it the same for rbac.
/lgtm
/approve
grokspawn
commented
Jun 14, 2024
Ah! I had leftover artifacts there after running the test for you this morning, and presumed that path was still used. If vestigial, ignore! |
Description
It looks like #888 we moved rbac manifests, but did not update controller-gen output path. This PR should fix this.
Reviewer Checklist