Uh oh!
There was an error while loading. Please reload this page.
🌱 Fix codecov-action params - #949
Merged
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #949 +/- ##
==========================================
+ Coverage 79.34% 80.23% +0.88%
==========================================
Files 16 16 Lines 1104 1103 -1 ==========================================
+ Hits 876 885 +9 + Misses 158 151 -7 + Partials 70 67 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
marked this pull request as ready for review
June 17, 2024 14:43
m1kola
enabled auto-merge
June 17, 2024 15:40
m1kola
marked this pull request as draft
June 17, 2024 16:00
auto-merge was automatically disabled
June 17, 2024 16:00
Pull request was converted to draft
* `functionalities` param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default. * Adding `disable_search` because we do not need for the codecov action to search for coverage files: we explicitly provide files. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
marked this pull request as ready for review
June 17, 2024 16:05
m1kola
enabled auto-merge
June 18, 2024 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
functionalitiesparam is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default.disable_searchbecause we do not need for the codecov action to search for coverage files: we explicitly provide files.This solves:
Reviewer Checklist