Skip to content

✨ Update to catalogd v0.17.0 to share a common certificate issuer - #970

Merged
tmshort merged 2 commits into
operator-framework:mainfrom
tmshort:kustomize
Jul 3, 2024
Merged

✨ Update to catalogd v0.17.0 to share a common certificate issuer#970
tmshort merged 2 commits into
operator-framework:mainfrom
tmshort:kustomize

Conversation

@tmshort

@tmshorttmshort commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

Description

Update to catalogd v0.17.0 to share a common certificate issuer

Fixes: #1000

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@netlify

netlifyBot commented Jun 25, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commitbb53f26
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66858985f7e5e60008817fed
😎 Deploy Previewhttps://deploy-preview-970--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jun 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (ceba614) to head (bb53f26).

Additional details and impacted files
@@ Coverage Diff @@## main #970 +/- ##
=======================================
Coverage 77.19% 77.19% =======================================
Files 17 17 Lines 1206 1206 =======================================
Hits 931 931 Misses 193 193 Partials 82 82 
FlagCoverage Δ
e2e56.54% <ø> (ø)
unit51.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort

Copy link
Copy Markdown
ContributorAuthor

@tmshorttmshort mentioned this pull request Jun 27, 2024
26 tasks
joelanford
joelanford previously approved these changes Jun 27, 2024
Update to catalogd v0.17.0 to share a common certificate issuer
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshorttmshort changed the title WIP: Reorganize kustomize config to reduce duplicationUpdate to catalogd v0.17.0 to share a common certificate issuerJul 3, 2024
@tmshorttmshort changed the title Update to catalogd v0.17.0 to share a common certificate issuer✨ Update to catalogd v0.17.0 to share a common certificate issuerJul 3, 2024
@tmshort
tmshort marked this pull request as ready for review July 3, 2024 17:07
@tmshort
tmshort requested a review from a team as a code ownerJuly 3, 2024 17:07
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort

tmshort commented Jul 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Changes since @joelanford's original approval:

  • Include catalogd v0.17.0
  • Rename secure to cert-manager (consistent with catalogd)
  • Move the e2e and cert-manager configs into the overlays directory.
  • Drop the catalogd certificate volume, as catalogd and operator-controller now share a CA

@tmshort
tmshort enabled auto-merge July 3, 2024 17:32
@tmshort
tmshort added this pull request to the merge queue Jul 3, 2024
Merged via the queue into operator-framework:main with commit dd08e0cJul 3, 2024
@tmshort
tmshort deleted the kustomize branch July 3, 2024 17:54
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
…erator-framework#970)
* Reorganize config to support reusable components
Update to catalogd v0.17.0 to share a common certificate issuer
Signed-off-by: Todd Short <tshort@redhat.com>
* fixup! Reorganize config to support reusable components
Signed-off-by: Todd Short <tshort@redhat.com>
---------
Signed-off-by: Todd Short <tshort@redhat.com>
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update kustomize configuration in operator-controller

2 participants

@tmshort@joelanford