Uh oh!
There was an error while loading. Please reload this page.
✨ Add CRD Upgrade Safety Preflight check to the ClusterExtension controller - #979
Merged
everettraven merged 2 commits intoJun 27, 2024
Conversation
❌ Deploy Preview for olmv1 failed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #979 +/- ##
==========================================
- Coverage 79.40% 76.89% -2.51%
==========================================
Files 17 17 Lines 1170 1225 +55 ==========================================
+ Hits 929 942 +13 - Misses 165 201 +36 - Partials 76 82 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rashmigottipatiforce-pushed
the
enable-crd-upgrade-safety-checks
branch
3 times, most recently
from
June 25, 2024 16:32
de72c86 to
86634d8CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rashmigottipatiforce-pushed
the
enable-crd-upgrade-safety-checks
branch
from
June 27, 2024 16:54
af4db2b to
da48d55Compareeverettraven
previously approved these changes
Jun 27, 2024
everettraven
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM - thanks @rashmigottipati !
Would love to see a demo of this functioning in the next community call!
Uh oh!
There was an error while loading. Please reload this page.
rashmigottipatiforce-pushed
the
enable-crd-upgrade-safety-checks
branch
from
June 27, 2024 20:15
da48d55 to
d84277fCompareeverettraven
previously approved these changes
Jun 27, 2024
rashmigottipatiforce-pushed
the
enable-crd-upgrade-safety-checks
branch
from
June 27, 2024 20:19
d84277f to
7ac4221CompareUh oh!
There was an error while loading. Please reload this page.
…ller Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipatiforce-pushed
the
enable-crd-upgrade-safety-checks
branch
from
June 27, 2024 20:34
7ac4221 to
06914d2Compareeverettraven
approved these changes
Jun 27, 2024
everettraven
enabled auto-merge
June 27, 2024 20:41
everettraven
added this pull request to the merge queue
Jun 27, 2024
4 tasks
4 tasks
This was referenced Jul 5, 2024
perdasilva pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
…roller (operator-framework#979) * Add CRD Upgrade Safety Preflight check to the ClusterExtension controller Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * add nil pointer check Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> --------- Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClusterExtensioncontroller to be configured with preflight checks and run them if they're enabledFixes#877
Reviewer Checklist