Skip to content

🌱 Add -count=1 to local e2e tests to avoid caching - #980

Merged
grokspawn merged 1 commit into
operator-framework:mainfrom
tmshort:count1
Jun 25, 2024
Merged

🌱 Add -count=1 to local e2e tests to avoid caching#980
grokspawn merged 1 commit into
operator-framework:mainfrom
tmshort:count1

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

Fixes issues with golang caching during e2e tests.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@tmshort
tmshort marked this pull request as ready for review June 25, 2024 18:01
@tmshort
tmshort requested a review from a team as a code ownerJune 25, 2024 18:01
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@netlify

netlifyBot commented Jun 25, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit210fedb
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/667b0604fdbb930008bca40d
😎 Deploy Previewhttps://deploy-preview-980--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort

Copy link
Copy Markdown
ContributorAuthor

This affects only your local tests, CI tests are run in an environment where the cache is already clean.

@codecov

codecovBot commented Jun 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (2eca31d) to head (210fedb).

Additional details and impacted files
@@ Coverage Diff @@## main #980 +/- ##
=======================================
Coverage 79.40% 79.40% =======================================
Files 17 17 Lines 1170 1170 =======================================
Hits 929 929 Misses 165 165 Partials 76 76 
FlagCoverage Δ
e2e57.35% <ø> (ø)
unit54.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawngrokspawn changed the title 🌱 Add -count=1 to e2e tests to avoid caching🌱 Add -count=1 to local e2e tests to avoid cachingJun 25, 2024
@grokspawn
grokspawn added this pull request to the merge queue Jun 25, 2024
Merged via the queue into operator-framework:main with commit 500397eJun 25, 2024
@tmshort
tmshort deleted the count1 branch June 26, 2024 14:59
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tmshort@grokspawn