Skip to content

🌱 Remove comment about retries. - #981

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:rm-comment
Jun 26, 2024
Merged

🌱 Remove comment about retries.#981
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:rm-comment

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

We'll use the default exponential backoff behavior

Fix#882

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

We'll use the default exponential backoff behavior
Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@tmshort
tmshort marked this pull request as ready for review June 26, 2024 15:10
@tmshort
tmshort requested a review from a team as a code ownerJune 26, 2024 15:11
@openshift-ciopenshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@netlify

netlifyBot commented Jun 26, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit1680166
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/667c2f8220e7150008e3a918
😎 Deploy Previewhttps://deploy-preview-981--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort
tmshort enabled auto-merge June 26, 2024 15:16
@codecov

codecovBot commented Jun 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (500397e) to head (1680166).

Additional details and impacted files
@@ Coverage Diff @@## main #981 +/- ##
=======================================
Coverage 79.40% 79.40% =======================================
Files 17 17 Lines 1170 1170 =======================================
Hits 929 929 Misses 165 165 Partials 76 76 
FlagCoverage Δ
e2e57.78% <ø> (+0.43%)⬆️
unit54.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort
tmshort added this pull request to the merge queue Jun 26, 2024

@dtfranzdtfranz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Merged via the queue into operator-framework:main with commit 208e584Jun 26, 2024
@tmshort
tmshort deleted the rm-comment branch June 26, 2024 15:42
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
We'll use the default exponential backoff behavior
Signed-off-by: Todd Short <tshort@redhat.com>
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Limit the number of unpack retries

2 participants

@tmshort@dtfranz