Uh oh!
There was an error while loading. Please reload this page.
⚠️ Remove HasValidBundle condition - #990
Merged
m1kola merged 1 commit intoJun 28, 2024
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #990 +/- ##
==========================================
+ Coverage 76.89% 77.19% +0.29%
==========================================
Files 17 17 Lines 1225 1206 -19 ==========================================
- Hits 942 931 -11 + Misses 201 193 -8
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
marked this pull request as ready for review
June 28, 2024 12:33
m1kola
commented
Jun 28, 2024
MemberAuthor
go-apidiff is expected to fail because I'm chasing the API here. |
bentito
reviewed
Jun 28, 2024
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kolaforce-pushed
the
remove_HasValidBundle_condition
branch
from
June 28, 2024 12:55
32fde13 to
d1bda18Comparebentito
commented
Jun 28, 2024
Contributor
/lgtm |
m1kola
added this pull request to the merge queue
Jun 28, 2024
This was referenced Jul 5, 2024
perdasilva pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes#989 by removing the condition and solves an E2E flake.
Note: in this brief were are revisiting
ClusterExtensionconditions and their reasons. One of the points is about removal ofHasValidBundlecondition type.The brief is still in review, but I would like to move forward with this change as it resolves a flake I hit regularly (especially locally).
Reviewer Checklist