Skip to content

Add offered qos incompatible event and event executor test - #11

Merged
ivanpauno merged 6 commits into
feature/eventsfrom
ivanpauno/add-offered-qos-incompatible-event
Aug 20, 2020
Merged

Add offered qos incompatible event and event executor test#11
ivanpauno merged 6 commits into
feature/eventsfrom
ivanpauno/add-offered-qos-incompatible-event

Conversation

@ivanpauno

@ivanpaunoivanpauno commented Aug 19, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

(edit) #10 has already been merged.

This PR is build on top of #10.

It adds a new publisher event status: OfferedQosIncompatible.
That new event status is used to test the executor code in #10, which surprisingly works without changes.

There are some other cosmetic changes here.

I will rebase and redirect the PR to feature/events when #10 gets merged.

@ivanpaunoivanpauno added the enhancement New feature or request label Aug 19, 2020
@ivanpaunoivanpauno self-assigned this Aug 19, 2020
jacobperron
jacobperron reviewed Aug 19, 2020
View reviewed changes
Comment threadrcljava/src/main/java/org/ros2/rcljava/events/publisher_statuses/OfferedQosIncompatible.java
Comment threadrcljava/src/test/java/org/ros2/rcljava/SpinTest.java Outdated
@jacobperron

jacobperron commented Aug 19, 2020

Copy link
Copy Markdown

surprisingly works without changes.

😂

jacobperron
jacobperron approved these changes Aug 19, 2020
View reviewed changes

@jacobperronjacobperron left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the minor comments above, this LGTM

@ivanpauno
Add OfferedQosIncompatible publisher event status
14505eb
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add OfferedQosIncompatible publisher event status
ca698ed
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Remove unnecesary print
d7ad984
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/add-offered-qos-incompatible-event branch from 9951769 to d7ad984CompareAugust 20, 2020 13:06
@ivanpauno
ivanpauno changed the base branch from ivanpauno/events-executor-support to feature/eventsAugust 20, 2020 13:06
@ivanpauno
ivanpauno marked this pull request as ready for review August 20, 2020 13:08
@ivanpauno

ivanpauno commented Aug 20, 2020

Copy link
Copy Markdown
CollaboratorAuthor

I have rebased feature/events against foxy-devel, and this branch against feature/events.
In that way, we can see CI being exercised now 😃 .

@ivanpauno
Fix string comparisons
ce1ba9f
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Compatibility with foxy
1fbeb17
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno

ivanpauno commented Aug 20, 2020•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@jacobperron there are some event statuses that we want but are not available in foxy (e.g. message lost), should we create a galactic-devel branch?

(edit) that should be done after completing basic event handling support in the foxy branch

@ivanpauno

ivanpauno commented Aug 20, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Unrelated, but I want to get rid of all stale branches.
Do we need to keep some of them or can I delete them all?

@ivanpauno
Foxy compatibility, take 2
18c020f
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
ivanpauno merged commit f36782a into feature/eventsAug 20, 2020
@ivanpauno
ivanpauno deleted the ivanpauno/add-offered-qos-incompatible-event branch August 20, 2020 15:48
This was referenced Aug 20, 2020
Merged
Merged
@jacobperron

jacobperron commented Aug 24, 2020

Copy link
Copy Markdown

@ivanpauno

there are some event statuses that we want but are not available in foxy (e.g. message lost), should we create a galactic-devel branch?

Yeah, feel free to create a galatic-devel branch when the time is right.

Unrelated, but I want to get rid of all stale branches.

Go ahead and delete stale branches 👍

@ivanpaunoivanpauno mentioned this pull request Aug 28, 2020
Merged
ivanpauno added a commit that referenced this pull request Aug 31, 2020
@ivanpauno
Add offered qos incompatible event and event executor test (#11)
81a6342
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit that referenced this pull request May 17, 2021
@ivanpauno
Add offered qos incompatible event and event executor test (#11)
cc972c7
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jan 14, 2022
@ivanpauno
Add offered qos incompatible event and event executor test (osrf#11)
e80c5df
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpaunoivanpauno mentioned this pull request Jan 14, 2022
Merged
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jan 25, 2022
@ivanpauno
Add offered qos incompatible event and event executor test (osrf#11)
0565917
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacobperronjacobperronjacobperron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpaunoivanpauno

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanpauno@jacobperron