Skip to content

Port rcl events support - #206

Merged
ivanpauno merged 11 commits into
mainfrom
ivanpauno/port-rcl-events-support
Jan 25, 2022
Merged

Port rcl events support#206
ivanpauno merged 11 commits into
mainfrom
ivanpauno/port-rcl-events-support

Conversation

@ivanpauno

@ivanpaunoivanpauno commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

@ivanpauno
Some code that compiles and doesn't break existing tests (osrf#10)
b9e9fdd
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add offered qos incompatible event and event executor test (osrf#11)
e80c5df
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Move events.publisher_statuses to publisher.statuses (osrf#12)
af60743
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add support for events in subscriptions (osrf#13)
1a50f3f
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add RequestedQosIncompatible subscription event status (osrf#14)
6c41709
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Test subscription events (osrf#15)
d3d740f
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add OfferedDeadlineMissed QoS event (osrf#17)
ac6f493
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Autoremove EventHandler from parent entity (osrf#16)
7e25190
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add RequestedDeadlineMissed subscription event (osrf#19)
a7b976d
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add LivelinessChanged subscription event (osrf#18)
ab00818
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add missing returns (osrf#23)
cb1c8fd
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpaunoivanpauno self-assigned this Jan 14, 2022
jacobperron
jacobperron approved these changes Jan 24, 2022
View reviewed changes

@jacobperronjacobperron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno
ivanpauno merged commit 434e6f5 into mainJan 25, 2022
@ivanpauno
ivanpauno deleted the ivanpauno/port-rcl-events-support branch January 25, 2022 13:20
@jacobperronjacobperron mentioned this pull request May 18, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperronjacobperronjacobperron approved these changes

Assignees

@ivanpaunoivanpauno

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanpauno@jacobperron