Skip to content

Add getPublishersInfo method to Node - #26

Merged
ivanpauno merged 4 commits into
galactic-develfrom
ivanpauno/introspect-qos
Sep 11, 2020
Merged

Add getPublishersInfo method to Node#26
ivanpauno merged 4 commits into
galactic-develfrom
ivanpauno/introspect-qos

Conversation

@ivanpauno

@ivanpaunoivanpauno commented Sep 1, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Depends on #25.
Depends on #30.

This PR adds:

  • An EndpointInfo class, to describe the value return by getPublishersInfo and getSubscriptionsInfo (unimplemented).
  • Implements getPublishersInfo with proper unit testing.

@ivanpaunoivanpauno added the enhancement New feature or request label Sep 1, 2020
@ivanpaunoivanpauno self-assigned this Sep 1, 2020
This was referenced Sep 1, 2020
Merged
Merged
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/introspect-qos branch from 1903424 to 9c3036dCompareSeptember 1, 2020 21:22
@ivanpaunoivanpauno mentioned this pull request Sep 3, 2020
Merged
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/update-qos-profile-take-2 branch from 6a7ef48 to 8201da2CompareSeptember 3, 2020 18:20
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/introspect-qos branch from 9c3036d to 74192f7CompareSeptember 3, 2020 18:22
@ivanpauno

ivanpauno commented Sep 8, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Converting to draft until #30 and #25 are merged.

@ivanpauno
ivanpauno marked this pull request as draft September 8, 2020 14:22
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/update-qos-profile-take-2 branch from 8201da2 to 2648f10CompareSeptember 8, 2020 21:13
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/introspect-qos branch from 41f516f to 7bd6cc4CompareSeptember 8, 2020 21:17
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/update-qos-profile-take-2 branch from 2648f10 to 0a9fb5fCompareSeptember 8, 2020 21:26
Base automatically changed from ivanpauno/update-qos-profile-take-2 to galactic-develSeptember 9, 2020 17:51
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/introspect-qos branch from 7bd6cc4 to 0c3bc7dCompareSeptember 9, 2020 21:00
@ivanpauno
ivanpauno marked this pull request as ready for review September 9, 2020 21:00
jacobperron
jacobperron reviewed Sep 10, 2020
View reviewed changes
Comment threadrcljava/src/main/cpp/org_ros2_rcljava_graph_EndpointInfo.cpp
Comment threadrcljava/src/main/cpp/org_ros2_rcljava_graph_EndpointInfo.cpp
Comment threadrcljava/src/main/cpp/org_ros2_rcljava_node_NodeImpl.cpp
Comment threadrcljava/src/main/cpp/org_ros2_rcljava_node_NodeImpl.cpp Outdated
Comment threadrcljava/src/main/cpp/org_ros2_rcljava_node_NodeImpl.cpp Outdated
@ivanpauno
* Add EndpointInfo class.
4c7c1be
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Address peer review comments
0024d68
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
ivanpaunoforce-pushed the ivanpauno/introspect-qos branch from 0c3bc7d to 0024d68CompareSeptember 10, 2020 22:02
@ivanpauno
Use rcpputils scope_exit
111fab9
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
jacobperron approved these changes Sep 11, 2020
View reviewed changes

@jacobperronjacobperron left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment.

Comment threadrcljava/src/main/cpp/org_ros2_rcljava_node_NodeImpl.cpp Outdated
@ivanpauno
Address peer review comment
73fba78
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
ivanpauno merged commit 7e2b15e into galactic-develSep 11, 2020
@ivanpauno
ivanpauno deleted the ivanpauno/introspect-qos branch September 11, 2020 19:18
@ivanpaunoivanpauno mentioned this pull request Sep 16, 2020
Merged
ivanpauno added a commit that referenced this pull request May 17, 2021
@ivanpauno
Add getPublishersInfo method to Node (#26)
40ef1df
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@ivanpauno@jacobperron
Add getPublishersInfo method to Node (osrf#26)
74db616
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@ivanpauno@jacobperron
Add getPublishersInfo method to Node (osrf#26)
533f764
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
@ivanpauno@jacobperron
Add getPublishersInfo method to Node (osrf#26)
dfea329
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jun 27, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
9b326a3
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpaunoivanpauno mentioned this pull request Jun 27, 2022
Merged
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jun 27, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
2ece6fb
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Aug 10, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
ece8300
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacobperronjacobperronjacobperron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpaunoivanpauno

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanpauno@jacobperron