Uh oh!
There was an error while loading. Please reload this page.
Port many graph introspection features from osrf fork - #221
Merged
Conversation
* Improve QoSProfile constructors * Add documentation to QoSProfile class * Add fromRCL method to QoSProfile * Use fromRCL to create the built-in qos profiles. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Add NameAndTypes class * Add getTopicNamesAndTypes method to Node Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
** Add EndpointInfo class. * Add getPublishersInfo method to Node. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…osrf#38) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpaunoforce-pushed
the
ivanpauno/port-from-osrf-fork-2
branch
from
June 27, 2022 18:48
ecd8a84 to
710fc2aCompareivanpauno
commented
Jul 12, 2022
ContributorAuthor
@jacobperron this is ready for review now |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Fixes a build issue with newer versions of ROS Rolling: fatal error: rcpputils/scope_exit.hpp: No such file or directory Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpaunoforce-pushed
the
ivanpauno/port-from-osrf-fork-2
branch
from
July 12, 2022 19:45
37222ef to
18faaa7Compareivanpauno
commented
Aug 4, 2022
ContributorAuthor
@jacobperron friendly ping |
jacobperron
approved these changes
Aug 9, 2022
jacobperron
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay review.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #220.
Ports: