Skip to content

Automated Release v0.1.4 - #668

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
v0.1.4
Closed

Automated Release v0.1.4#668
github-actions[bot] wants to merge 1 commit into
mainfrom
v0.1.4

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Auto-generated pull request creating version 0.1.4.

Changelog:

  • Update the docker image to Ubuntu 24. (632) [Fabian Ruffy]

Changelog:
- Update the docker image to Ubuntu 24. (632) [Fabian Ruffy]

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
github-actions Bot requested review from fruffy and jafingerhut August 12, 2026 13:43
@github-actions

Copy link
Copy Markdown
Contributor Author

Maintainers: Mark this PR as ready to trigger CI.

Please use Squash and merge to include the changelog in the release message.

@fruffy
fruffy marked this pull request as ready for review August 12, 2026 16:11
@chreekat

Copy link
Copy Markdown
Contributor

Interesting, this failed for some reason I can't immediately interpret.

@jafingerhut

Copy link
Copy Markdown
Contributor

Interesting, this failed for some reason I can't immediately interpret.

I suspect it is because the container being used has Python packages installed system-wide, and the failing script is trying to add more packages using pip install ..., but as a non-root user.

I think one option for handling this is to always install Python packages during builds into an explicitly chosen Python virtual environment, which is selected by doing source $MYVENV_DIR/bin/activate (which in turn assigns a value to the environment variable VIRTUAL_ENV). That would seem to require adding such commands to all p4lang repositories that use these containers, and the necessary commands to create such a virtual environment in any docker scripts that create a docker image that isn't based on a different p4lang docker image.

@jafingerhut

Copy link
Copy Markdown
Contributor

Interesting, this failed for some reason I can't immediately interpret.

I suspect it is because the container being used has Python packages installed system-wide, and the failing script is trying to add more packages using pip install ..., but as a non-root user.

I think one option for handling this is to always install Python packages during builds into an explicitly chosen Python virtual environment, which is selected by doing source $MYVENV_DIR/bin/activate (which in turn assigns a value to the environment variable VIRTUAL_ENV). That would seem to require adding such commands to all p4lang repositories that use these containers, and the necessary commands to create such a virtual environment in any docker scripts that create a docker image that isn't based on a different p4lang docker image.

A small correction to the above message. The error occurs when running a pip install command, and the destination where the package should be installed is a system-wide directory, e.g. /usr/lib/python<x>.<y>/, or /usr/local/lib/python<x>.<y>/, and then with recent versions of pip as installed by default on Ubuntu 24.04 and later versions of Ubuntu, it will give the error message that this CI check is failing with, because there is a new check that prevents one from using pip to install in system-wide directories.

Many p4lang projects CI scripts attempt to install Python packages in system-wide directories, because it always worked before. I think we should move away from doing so, because of the newer behavior of pip (which has been since some version around 2023, I think, so not exactly new behavior).

@jafingerhut

Copy link
Copy Markdown
Contributor

The changes in PR #669 (or something similarly effective) should enable the PI build & test to work again, with the new Ubuntu 24.04-based docker images.

@chreekat

Copy link
Copy Markdown
Contributor

Let's close this one and let the next one pick up the fixes.

@chreekat chreekat closed this Sep 10, 2026
@chreekat
chreekat deleted the v0.1.4 branch September 10, 2026 07:08
@jafingerhut

Copy link
Copy Markdown
Contributor

Let's close this one and let the next one pick up the fixes.

Sounds reasonable. PR #670 was merged on this repo, that should hopefully enable the next automated release CI tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants