Update name of Ubuntu 24.04 Docker image used as input by jafingerhut · Pull Request #669 · p4lang/PI

jafingerhut · 2026-09-02T06:17:40Z

No description provided.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

…ckages Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

ones that are more easily installable on Ubuntu 24.04 Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

fruffy · 2026-09-02T14:36:02Z

        docker run -w /PI pi bash -c \
-          'apt-get update && apt-get install -y python3-pip && \
-          python3 -m pip install ptf scapy grpcio googleapis-common-protos protobuf==3.20 && \
+          'sudo apt-get update && sudo apt-get install -y build-essential python3-dev &&


sudo is not available in docker iirc.

Looks like this should be part of the third-party image, if it is missing?

For the record, also okay to add it here, but likely should be in the build file.

Not when we run tests. If the tests fail, our image is incomplete

Thanks for the advice. Right now I am looking into some failures to compile the PI code when configure is used to enable all of the optional pieces. I have compiled PI with a subset of its options enabled for years on Ubuntu 24.04 and gotten it to pass tests when linked with simple_switch_grpc and run through all of p4c's tests, for example, but apparently there is PI C++ code that does not compile at all with the default version of GCC installed by apt on Ubuntu 24.04, that I haven't ever tried to compile before now.

We are experiencing this because either (a) no one has ever tried this before and seen the failures, or (b) they have experienced them, but haven't bothered to report them.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

jafingerhut · 2026-09-03T04:25:04Z

@fruffy This should be passing all tests now.

I also did these changes:

updated the version of clang tested. The older ones did not even have apt packages available on Ubuntu 24.04
disabled --with-proto configure option in Dockerfile.bmv2. Enabling that causes compile-time errors with some source files that I don't know to fix at this time.
disabled running of ./tools/check_style.sh at the end. There are failures there that I haven't looked into how to fix, but the better answer there is probably to use code style/lint checking tools that are used in other C++ and Python code in other p4lang projects.

fruffy · 2026-09-04T16:33:21Z

    strategy:
      matrix:
        include:
+        - cxx: clang++-18


Can we make this generic like we do with gcc?

Done in commit 16, passes CI tests still.

fruffy · 2026-09-04T16:34:30Z

        docker run -w /PI pi bash -c \
-          'apt-get update && apt-get install -y python3-pip && \
-          python3 -m pip install ptf scapy grpcio googleapis-common-protos protobuf==3.20 && \
+          'apt-get update && apt-get install -y build-essential python3-dev &&


This should be part of the build step, not the test step. If the tests require this to pass we are shipping a broken image

fruffy · 2026-09-04T16:35:01Z

    apt-get install -y --no-install-recommends $PI_DEPS $PI_RUNTIME_DEPS && \
    ./autogen.sh && \
-    ./configure --enable-Werror --with-bmv2 --with-proto --with-cli --with-internal-rpc --with-sysrepo && \
+    # TODO: Change --without-proto to --with-proto when we learn how


What is the actual error here? Maybe it is a trivial fix

You can see the errors in the logs of this similar PR, which I created in parallel to try out some variations on this one.

I have since found fairly small changes to the C++ code to keep the proto option enabled during PI conigure step. The changes are in the PR #670, which I suspect may replace this one soon. I plan to make a few more commits to #670 soon to try to move the installation of Python packages into the build step rather than the test step, as you commented on for this PR.

instead of picking a particular version number Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

…lures Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

jafingerhut · 2026-09-06T19:36:22Z

Closing this PR, as I recommend reviewing PR #670 instead.

Update name of Ubuntu 24.04 Docker image used as input

c542bb2

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

jafingerhut requested a review from fruffy September 2, 2026 06:17

Use uv to install Python packages

e2c8bef

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Sep 2, 2026

jafingerhut added 3 commits September 2, 2026 09:33

Install a couple more apt packages that should help install python pa…

4413556

…ckages Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Update to more recent versions of clang for testing

d5a71ff

ones that are more easily installable on Ubuntu 24.04 Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Remove clang from build matrix to see if gcc works

72b960e

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

fruffy reviewed Sep 2, 2026

View reviewed changes

jafingerhut added 10 commits September 2, 2026 19:17

sudo is not installed by default in container

fd527b3

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Also install p4runtime Python package

1259510

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Install clang-format

3537de6

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Disable the code style checks for now

551d1cd

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Try disabling bmv2 option for PI in Dockerfile.bmv2

9952cde

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Try different configure options in Dockerfile.bmv2

224ef2c

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Remove commented-out script cmds

768d095

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Remove unnecessary debug show cmd

c1c4f30

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Try re-enabling clang

e384228

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Add comment to remind us to re-enable --with-proto when possibly

7b24189

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

jafingerhut mentioned this pull request Sep 3, 2026

Automated Release v0.1.4 #668

Closed

jafingerhut requested a review from chreekat September 3, 2026 19:36

fruffy reviewed Sep 4, 2026

View reviewed changes

jafingerhut added 7 commits September 4, 2026 15:54

Use default version of clang / clang++ for the distribution

00433f3

instead of picking a particular version number Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Move Python package installs to build step, from test step

def97cb

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

More tweaks to see if it will enable tests to pass

e955bb9

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Restore changes back to commit 16 version

32284fd

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Add extra debug show cmds

72360b6

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Try forcing shell to be /bin/bash in Dockerfile.bmv2

af12125

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

Add another level of subshell in Dockerfile.bmv2 to avoid masking fai…

a0e0673

…lures Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

jafingerhut mentioned this pull request Sep 6, 2026

Change to Dockerfiles that prevents them from masking failed builds #670

Merged

jafingerhut closed this Sep 6, 2026

Navigation Menu

Uh oh!

Update name of Ubuntu 24.04 Docker image used as input - #669

Update name of Ubuntu 24.04 Docker image used as input#669
jafingerhut wants to merge 22 commits into
p4lang:mainfrom
jafingerhut:update-docker-image-name-for-ubuntu-2404

jafingerhut commented Sep 2, 2026

Uh oh!

fruffy Sep 2, 2026

Uh oh!

fruffy Sep 2, 2026

Uh oh!

jafingerhut Sep 2, 2026

Uh oh!

jafingerhut commented Sep 3, 2026

Uh oh!

fruffy Sep 4, 2026

Uh oh!

jafingerhut Sep 4, 2026

Uh oh!

fruffy Sep 4, 2026

Uh oh!

fruffy Sep 4, 2026

Uh oh!

jafingerhut Sep 5, 2026

Uh oh!

jafingerhut Sep 5, 2026

Uh oh!

jafingerhut Sep 5, 2026

Uh oh!

jafingerhut commented Sep 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jafingerhut commented Sep 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jafingerhut commented Sep 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jafingerhut commented Sep 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants