Remove String.format from exception creation by schlosna · Pull Request #1027 · palantir/conjure-java-runtime-api

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

schlosna · 2023-09-14T02:26:00Z

Before this PR

After this PR

==COMMIT_MSG==
Remove String.format from exception creation
==COMMIT_MSG==

Possible downsides?

changelog-app · 2023-09-14T02:26:03Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Remove String.format from exception creation

Check the box to generate changelog(s)

Generate changelog entry

carterkozak · 2023-09-14T02:39:43Z


 public UnknownRemoteException(int status, String body) {
- super(String.format("Response status: %s", status));
+ super("Response status: " + status);


Feel free to include the List.of optimization in this PR if you like

carterkozak

Thanks! Feel free to re-add merge-when-ready as is, I wanted to give you the option to add the args list optimization as well.

schlosna · 2023-09-14T02:53:00Z

+ @Unsafe
 @Override
 public List<Arg<?>> getArgs() {
- List<Arg<?>> args = new ArrayList<>(2);
- args.add(SafeArg.of("status", getStatus()));
- args.add(UnsafeArg.of("body", getBody()));
- return Collections.unmodifiableList(args);
+ return List.of(SafeArg.of("status", getStatus()), UnsafeArg.of("body", getBody()));


@carterkozak Note that changing this to using List.of triggered a SafeLoggingPropagation warning as the check could do deeper analysis, so I did a -PerrorProneApply=SafeLoggingPropagation as a separate commit. Let me know if you want to keep these as-is before merging or split into a separate follow-on PR.
> Task :errors:compileJava /Volumes/git/palantir/conjure-java-runtime-api/errors/src/main/java/com/palantir/conjure/java/api/errors/UnknownRemoteException.java:54: Note: [SafeLoggingPropagation] Safe logging annotations should be propagated to encapsulating elements to allow static analysis tooling to work with as much information as possible. This check can be auto-fixed using `./gradlew classes testClasses -PerrorProneApply=SafeLoggingPropagation` public List<Arg<?>> getArgs() { ^ (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks) Did you mean '@Unsafe @Override'?

I think the changes outside of this file were handled by a recent baseline upgrade on develop (#1024), so the diff is pretty small in reality.
Unsafe annotations on getArgs look a bit off, but it's technically correct because it would be invalid to invoke something like SafeArg.of("key", unknownRemoteException.getArgs()). It's not something that we'd be likely to do, so the annotation probably isn't terribly valuable in this instance, but the pattern it's matching on is a safety unaware return type (Arg can be safe or unsage) where the method is known to return an @Unsafe type or value (in this case UnsafeArg).

svc-autorelease · 2023-09-14T03:04:57Z

Released 2.37.0

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Remove String.format from exception creation
9d9a900

schlosna requested a review from carterkozak September 14, 2023 02:26

schlosna mentioned this pull request Sep 14, 2023
(Unknown)RemoteException implement ResponseStatus #1026
Closed

Add generated changelog entries
8c094a2

schlosna added merge when ready autorelease labels Sep 14, 2023

carterkozak reviewed Sep 14, 2023
View reviewed changes

carterkozak removed the merge when ready label Sep 14, 2023

carterkozak approved these changes Sep 14, 2023
View reviewed changes

schlosna added 2 commits September 13, 2023 22:46

Use List.of for args
3583af1

errorProneApply=SafeLoggingPropagation
ca8dc5b

schlosna commented Sep 14, 2023
View reviewed changes

schlosna requested a review from carterkozak September 14, 2023 02:53

carterkozak added the merge when ready label Sep 14, 2023

bulldozer-botBot merged commit 8da6b2d into developSep 14, 2023

bulldozer-botBot deleted the ds/concat branch September 14, 2023 03:04

mpritham mentioned this pull request Jun 20, 2025
Add EndpointServiceException #1352
Merged

Uh oh!

Conversation

schlosna commented Sep 14, 2023

Before this PR

After this PR

Possible downsides?

Uh oh!

changelog-appBot commented Sep 14, 2023• edited by schlosna Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generate changelog in changelog/@unreleased

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carterkozak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svc-autorelease commented Sep 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

schlosna commented Sep 14, 2023

Before this PR

After this PR

Possible downsides?

Uh oh!

changelog-appBot commented Sep 14, 2023• edited by schlosna Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generate changelog in changelog/@unreleased

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carterkozak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svc-autorelease commented Sep 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

schlosna commented Sep 14, 2023

Before this PR

After this PR

Possible downsides?

Uh oh!

changelog-appBot commented Sep 14, 2023• edited by schlosna Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generate changelog in changelog/@unreleased

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carterkozak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

changelog-appBot commented Sep 14, 2023•
edited by schlosna
Loading

Generate changelog in `changelog/@unreleased`

changelog-appBot commented Sep 14, 2023•
edited by schlosna
Loading

Generate changelog in `changelog/@unreleased`

changelog-appBot commented Sep 14, 2023•
edited by schlosna
Loading

Generate changelog in `changelog/@unreleased`

changelog-appBot commented Sep 14, 2023•
edited by schlosna
Loading

Generate changelog in `changelog/@unreleased`