') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); New flags to listen to all interfaces by chevdor · Pull Request #495 · paritytech/substrate · GitHub
Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

New flags to listen to all interfaces - #495

Merged
gavofyork merged 2 commits into
paritytech:masterfrom
chevdor:will-439-network-interface
Aug 9, 2018
Merged

New flags to listen to all interfaces#495
gavofyork merged 2 commits into
paritytech:masterfrom
chevdor:will-439-network-interface

Conversation

@chevdor

@chevdorchevdor commented Aug 3, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

The current version listens only on 127.0.0.1.

This change is required for containerised versions to run properly.

Adds:

  • --ws-external
  • --rpc-external
USAGE:
polkadot [FLAGS] [OPTIONS] [SUBCOMMAND]
FLAGS:
--dev Run in development mode; implies --chain=dev --validator --key Alice
-h, --help Prints help information
--light Run in light client mode
--no-telemetry Should not connect to the Polkadot telemetry server (telemetry is on by default on global
chains)
⥤ --rpc-external Listen to all rpc interfaces (Default is local)
-t, --telemetry Should connect to the Polkadot telemetry server (telemetry is off by default on local chains)
--validator Enable validator mode
-V, --version Prints version information
⥤ --ws-external Listen to all web socket interfaces (Default is local)
<...>

@chevdorchevdor added the A0-please_review Pull request needs code review. label Aug 3, 2018
@chevdor
chevdorforce-pushed the will-439-network-interface branch from c991fe0 to cfeaccfCompareAugust 3, 2018 15:27
@chevdorchevdor mentioned this pull request Aug 3, 2018
Closed
@chevdor
chevdor requested a review from tomakaAugust 3, 2018 16:55
@gavofyorkgavofyork added A4-gotissues and removed A0-please_review Pull request needs code review. labels Aug 3, 2018
@gavofyork

gavofyork commented Aug 3, 2018

Copy link
Copy Markdown
Member

opening the RPC to external hosts by default is a little too promiscuous for my liking. i think this will have to be fixed properly.

@chevdor

chevdor commented Aug 3, 2018

Copy link
Copy Markdown
ContributorAuthor

Yes, I can understand.
If we go safety first, we will have less nodes (missing out all those docker nodes).
If we take this fix without #494 we increase the risks. I think this is however acceptable for a PoC stage with only a testnet. I would gladly take a look at #494 but I have no idea how long it would take me, I have no clue how this was done in parity.

@chevdor

chevdor commented Aug 3, 2018

Copy link
Copy Markdown
ContributorAuthor

--dev already carries a meaning. Would a generic --unsafe mode be an acceptable way to pack tweaks like this one?

So secure by default, only the local interface but open with --unsafe.

@gavofyork

gavofyork commented Aug 4, 2018

Copy link
Copy Markdown
Member

Should just be:

  • add a couple of value-taking options in cli.yml (--ws-interface, --rpc-interface);
  • in cli/src/lib.rs, use .unwrap_or("127.0.0.1:9933") to give them the current default, then pass on into the config as before.

@chevdor

chevdor commented Aug 4, 2018

Copy link
Copy Markdown
ContributorAuthor

Ok I will take care of that.

@tomusdrw

tomusdrw commented Aug 5, 2018

Copy link
Copy Markdown
Contributor

Maybe we can try to avoid too many configuration flags for RPC servers for now? Can live with --expose or --external-rpc flag that sets the interfaces to 0.0.0.0? I'd be in favor of something more clever for the future (either the proxy or configuration files). I don't think that selecting a specific interface to listen on is super useful anyway - usually it's just localhost or "external/all"

@gavofyork

gavofyork commented Aug 5, 2018

Copy link
Copy Markdown
Member

fair enough - should make it even easier :)

@chevdor
chevdorforce-pushed the will-439-network-interface branch from cfeaccf to 0f8dd16CompareAugust 6, 2018 16:48
@chevdorchevdor changed the title Listen to all interfaces by defaultNew flags to listen to all interfacesAug 6, 2018
@chevdor
chevdorforce-pushed the will-439-network-interface branch from 0f8dd16 to b562955CompareAugust 6, 2018 16:50
@chevdor

chevdor commented Aug 7, 2018

Copy link
Copy Markdown
ContributorAuthor

I went with the naming suggested by @tomusdrw but flipped it. That allows having all the rpc related option as --rpc-foobar

tomusdrw
tomusdrw approved these changes Aug 7, 2018
View reviewed changes
Comment threadsubstrate/cli/src/cli.yml
long: rpc-external
help: Listen to all rpc interfaces (Default is local)
takes_value: false
- ws-external:

@tomusdrwtomusdrwAug 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is no point in running RPC externally but not WS, would merge the two flags to avoid clutter in CLI help.
In the future we will most likely run HTTP & WS transport on the same port anyway, so maybe it will be a good opportunity to merge the two options as well.

So I guees it's all right :)

@chevdorchevdorAug 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to be too pushy here and let for now the users decide. That allows at the moment a user to 'open up' WS while keeping RPC only local only. It may be better security-wise for now.

tomusdrw
tomusdrw suggested changes Aug 7, 2018
View reviewed changes
Comment threadsubstrate/cli/src/lib.rs Outdated
};

config.network.listen_address = Some(SocketAddr::new("0.0.0.0".parse().unwrap(), port));
config.network.listen_address = Some(SocketAddr::new("127.0.0.1".parse().unwrap(), port));

@tomusdrwtomusdrwAug 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this was changed? I think network should always listen externally.

@chevdorchevdorAug 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wuuhooo, sorry, this is a big mistake on my hand, good catch and sorry about that. Will fix.

@chevdor
chevdorforce-pushed the will-439-network-interface branch from b562955 to 2aabe80CompareAugust 7, 2018 08:32
@chevdorchevdor added the A0-please_review Pull request needs code review. label Aug 7, 2018
@gavofyork
gavofyork merged commit 620adb9 into paritytech:masterAug 9, 2018
@chevdor
chevdor deleted the will-439-network-interface branch August 9, 2018 07:39
dvdplm added a commit that referenced this pull request Aug 9, 2018
@dvdplm
Merge branch 'master' into refactor/substrate-state-machine-generic
cafe669
* master:
README: fixed typo in docker run command (#518)
Merge *_at methods. (#515)
New flags to listen to all interfaces (#495)
If contract reaches max depth, return Err (#503)
Some networking cleanups (#504)
Derivable Encode & Decode (#509)
substrate: return Option in all storage related RPC methods (#510)
Build with locked Cargo.lock on CI (#514)
Place call data into a newly allocated pages (#502)
gavofyork pushed a commit that referenced this pull request Aug 10, 2018
@chevdor@gavofyork
New flags to listen to all interfaces (#495)
2355463
* Add new flag to allow listening to all interfaces
Fix#439Fix#494
* Fix capitalisation
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
@andresilva
service: cleanup task spawning (paritytech#495)
ebf7ee2
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
@lexnv
Use tokio instead of async-std (paritytech#495)
6ce9983
* examples: Use tokio instead of std async
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* test-runtime: Use tokio instead of std async
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* subxt: Use tokio instead of std async
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
* examples: Use only necessary tokio features
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tomakatomakaAwaiting requested review from tomaka
2 more reviewers
@tomusdrwtomusdrwtomusdrw requested changes
@gavofyorkgavofyorkgavofyork approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_reviewPull request needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chevdor@gavofyork@tomusdrw