Some networking cleanups by tomaka · Pull Request #504 · paritytech/substrate

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

tomaka · 2018-08-07T13:06:09Z

Removed all the unused fields from NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such as max_handshakes) can easily be done at the time we implement them.
The listen_address and public_address are now a Multiaddr instead of a SocketAddr. This doesn't change much in practice for now.
Removed the IpFilter and NetworkIoMessage types and the dependency on the ipnetwork crate.

tomaka · 2018-08-07T13:23:21Z

- }
+	match swarm_controller.listen_on(shared.config.listen_address.clone()) {
+ Ok(new_addr) => {
+ debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr);


Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.

what would happen if there is something already listening on the specified multiaddr?

pepyakin · 2018-08-07T14:58:05Z

-	}
-
-	/// Create new default configuration for localhost-only connection with random port (usefull for testing)
+	/// Create new default configuration for localhost-only connection with random port (useful for testing)


hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?

Oh, I screwed up.

arkpar · 2018-08-08T08:54:43Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

tomaka · 2018-08-08T08:59:45Z

Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p?

I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement.

* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)

* Some networking cleanups * Fix tests * Fix wrong port in new_local

* Update cargo files * First round of build fixes * update lock file

This reverts commit 89ac39f.

…age-access Control non-root storage access

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Some networking cleanups
8efcae8

tomaka force-pushed the net-cleanups branch from 7923479 to 8efcae8Compare August 7, 2018 13:06

Fix tests
d8b6788

tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 7, 2018

tomaka commented Aug 7, 2018
View reviewed changes

gavofyork approved these changes Aug 7, 2018
View reviewed changes

gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2018

pepyakin reviewed Aug 7, 2018
View reviewed changes

Fix wrong port in new_local
ed22e5c

arkpar approved these changes Aug 8, 2018
View reviewed changes

gavofyork merged commit 59225c6 into paritytech:masterAug 8, 2018

tomaka deleted the net-cleanups branch August 8, 2018 18:09

gavofyork pushed a commit that referenced this pull request Aug 10, 2018
Some networking cleanups (#504)
8ed4ffc
* Some networking cleanups * Fix tests * Fix wrong port in new_local

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Update to latest substrate (paritytech#504)
89ac39f
* Update cargo files * First round of build fixes * update lock file

lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
Revert "Update to latest substrate (paritytech#504)" (paritytech#505)
f35a4db
This reverts commit 89ac39f.

liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Update docker (paritytech#504)
d81129d

liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Merge pull requestparitytech#504from subspace/control-non-root-stor…
b810baf
…age-access Control non-root storage access

helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
bump jsonrpsee to v0.10.1 (paritytech#504)
9330ba0
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

Uh oh!

Conversation

tomaka commented Aug 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pepyakinAug 7, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkpar commented Aug 8, 2018

Uh oh!

tomaka commented Aug 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tomaka commented Aug 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pepyakinAug 7, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkpar commented Aug 8, 2018

Uh oh!

tomaka commented Aug 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tomaka commented Aug 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pepyakinAug 7, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkpar commented Aug 8, 2018

Uh oh!

tomaka commented Aug 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pepyakinAug 7, 2018•
edited
Loading

pepyakinAug 7, 2018•
edited
Loading

pepyakinAug 7, 2018•
edited
Loading

pepyakinAug 7, 2018•
edited
Loading

pepyakinAug 7, 2018•
edited
Loading