Uh oh!
There was an error while loading. Please reload this page.
Use a common function for "cannot be empty" ValueError - #15489
Merged
Conversation
MemberAuthor
|
Girgiasforce-pushed
the
helpers-common-value-error-empty
branch
from
August 19, 2024 12:11
4f11fa2 to
314410fCompareyoukidearitai
approved these changes
Aug 19, 2024
youkidearitai
left a comment
Contributor
There was a problem hiding this comment.
LGTM from mbstring. Thanks.
devnexen
approved these changes
Aug 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Girgiasforce-pushed
the
helpers-common-value-error-empty
branch
from
August 20, 2024 14:17
89e35ad to
c47d283CompareIt not being empty is already checked by PHP_GETTEXT_DOMAIN_LENGTH_CHECK()
Girgiasforce-pushed
the
helpers-common-value-error-empty
branch
from
August 20, 2024 23:14
c47d283 to
34b57c9CompareMember
There was a problem hiding this comment.
The function name now no longer matches the message.
MemberAuthor
There was a problem hiding this comment.
Updated in-place in the last commit, which changes the wording from "cannot" to "must not"
Girgiasforce-pushed
the
helpers-common-value-error-empty
branch
from
August 21, 2024 12:43
34b57c9 to
c823ee4Comparendossche
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually.
Some extensions were not using the standard wording, so changed it by using the new helper.
There are also some drive-by refactoring that I noticed while changing the code to use the helper.